-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified python-parser code for building multi level fold tree. #64
Conversation
Thank you, this works for second level nodes -- tested via patching latest from ELPA. But not for anything indented beyond that for, examples nested loops, try-catch, etc. Is it possible to have these? As they are clearly indentation dependent. |
@sawan you could try removing the python specific parser from |
Ah... how do I do that please? |
many ways to do it. easiest is via the customize interface:
|
alternatively, with |
Done python parser for any block of codes (if try for, etc.. ) #91 |
This is great. |
This change pollutes the user's |
hey @conao3 maybe don't pop out of nowhere to shout negative things. it's rude behaviour. instead, you could have written something this: 'it seems this change introduced a function that looks like it's on the global python namespace ( see the difference? no bitching, no mention of blindly reverting (counterproductive suggestion) but an actionable improvement with an offer to help. in fact, opening a pull request to improve the situation would probably have taken you less time than writing your negative comment. you're welcome. |
In fact, I think it's better to use |
I'll merge a PR |
@wbolster Naoya and I have our differences sometimes, but I'll stand up for him here. He simply observed a problem. He was not rude. In contrast, your comment was very rude and completely uncalled for. What you accuse him of doing is actually what you have done. There are real people on the other end of these screens. What we're talking about is just code. There's no need to be hostile. |
While we may get confused about saying thank you, I simply want to say. Thank you, @alphapapa. Anyway, it's been over a week without any corrections since I reported. This package has many users and 56,000 over DLs from MELPA. FYI: @jcs090218 |
@gregsexton made it clear that he would merge a pr and since you have a clear idea on what the best fix would look like, a pull request is the way to get this issue to move forward. in any case, let's keep the right perspective: this seems a cosmetic issue only, and there is really no need to talk about
when a cosmetic issue isn't addressed within a few days. |
#55