Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No delta time parameters #1

Open
vidstige opened this issue Feb 28, 2021 · 0 comments
Open

No delta time parameters #1

vidstige opened this issue Feb 28, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@vidstige
Copy link

In the original paper a delta-time parameter is used, this allows duration to be expressed in seconds rather that frames, and also the viscosity and velocities and other vectors can have more sane units. In my humble opinion pixels/frame^2 is trickier to think about compared to pixels/s^2... 🤔 Furthermore, after studying the code it should be fairly easy to add a delta time parameter to both advect_diffuse() and project() functions. Possibly with default value of dt=1.

@GregTJ GregTJ added the enhancement New feature or request label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants