Source put data on other order

[silasrm]

Hi,

I've a array of options to Estado field:

array:28 [▼
  "AC" => "Acre"
  "AL" => "Alagoas"
  "AP" => "Amapá"
  "AM" => "Amazonas"
  "BA" => "Bahia"
  "CE" => "Ceara"
  "DF" => "Distrito Federal"
  "ES" => "Espirito Santo"
  "GO" => "Goiás"
  "MA" => "Maranhão"
  "MT" => "Mato Grosso"
  "MS" => "Mato Grosso do Sul"
  "MG" => "Minas Gerais"
  "PA" => "Para"
  "PB" => "Paraiba"
  "PR" => "Parana"
  "PE" => "Pernambuco"
  "PI" => "Piaui"
  "RN" => "Rio Grande do Norte"
  "RS" => "Rio Grande do Sul"
  "RJ" => "Rio de Janeiro"
  "RO" => "Rondônia"
  "RR" => "Roraima"
  "SC" => "Santa Catarina"
  "SE" => "Sergipe"
  "SP" => "São Paulo"
  "TO" => "Tocantins"
  "EX" => "Exterior"
]

And I'm set like a documentation:

$form2->source('estados', $estados);

And in html I use:

<select name="estado" id="estado">
                    <option value="">- selecione -</option>
                    <options source="estados" />
                </select>

But the form html returne with options in reverse order and with a empty in first position:

<select name="estado" id="estado" >
<option value=""></option><option selected="selected" value="">- selecione -</option>
<option value="EX">Exterior</option>
<option value="TO">Tocantins</option>
<option value="SP">São Paulo</option>
<option value="SE">Sergipe</option>
<option value="SC">Santa Catarina</option>
<option value="RR">Roraima</option>
<option value="RO">Rondônia</option>
<option value="RJ">Rio de Janeiro</option>
<option value="RS">Rio Grande do Sul</option>
<option value="RN">Rio Grande do Norte</option>
<option value="PI">Piaui</option>
<option value="PE">Pernambuco</option>
<option value="PR">Parana</option>
<option value="PB">Paraiba</option>
<option value="PA">Para</option>
<option value="MG">Minas Gerais</option>
<option value="MS">Mato Grosso do Sul</option>
<option value="MT">Mato Grosso</option>
<option value="MA">Maranhão</option>
<option value="GO">Goiás</option>
<option value="ES">Espirito Santo</option>
<option value="DF">Distrito Federal</option>
<option value="CE">Ceara</option>
<option value="BA">Bahia</option>
<option value="AM">Amazonas</option>
<option value="AP">Amapá</option>
<option value="AL">Alagoas</option>
<option value="AC">Acre</option>
</select>

Any solution?

[Gregwar]

Hello,

This is indeed a reproductible bug

[Gregwar]

Thanks for reporting
Should be fixed in master, can you confirm and close?

[silasrm]

@Gregwar the order is fixed. But, the empty option in first position continues:

<select name="estado" id="estado" >
<option value=""></option>
<option selected="selected" value="">- selecione -</option>
<option value="AC">Acre</option>
<option value="AL">Alagoas</option>
...
</select>

<select name="estado" id="estado">
                   <option value="">- selecione -</option>
                   <options source="estados" />
               </select>

[Gregwar]

Hello, I guess your field should be required Else, a blank field is added to allow the user entering nothing Le dim. 5 mars 2017 17:59, Silas Ribas Martins <notifications@github.com> a écrit :

…

@Gregwar <https://github.com/Gregwar> the order is fixed. But, the empty option in first position continues: <select name="estado" id="estado" > <option value=""></option> <option selected="selected" value="">- selecione -</option> <option value="AC">Acre</option> <option value="AL">Alagoas</option> ... </select> <select name="estado" id="estado"> <option value="">- selecione -</option> <options source="estados" /> </select> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWZrgVinmNdfgsMm0EokPfrIRSf8UCCks5riun1gaJpZM4MTTpG> .

[Gregwar]

I confess that this behaviour could be discussed Le dim. 5 mars 2017 18:00, Grégoire Passault <g.passault@gmail.com> a écrit :

…

Hello, I guess your field should be required Else, a blank field is added to allow the user entering nothing Le dim. 5 mars 2017 17:59, Silas Ribas Martins ***@***.***> a écrit : @Gregwar <https://github.com/Gregwar> the order is fixed. But, the empty option in first position continues: <select name="estado" id="estado" > <option value=""></option> <option selected="selected" value="">- selecione -</option> <option value="AC">Acre</option> <option value="AL">Alagoas</option> ... </select> <select name="estado" id="estado"> <option value="">- selecione -</option> <options source="estados" /> </select> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWZrgVinmNdfgsMm0EokPfrIRSf8UCCks5riun1gaJpZM4MTTpG> .

[silasrm]

@Gregwar I understand, But I desire set the "label" of this blank option.

[silasrm]

My idea

Add a attribute flag, named as without-empty-item, (won't replicated as element attributes) that says: this <select> hasn't a default empty option, without to use required attribute. But, if element is set as required, the default empty option won't added like before.

Example:

<select name="estado" id="estado" without-empty-item>
                    <option value="">- selecione -</option>
                    <options source="estados" />
                </select>

OR add attributes to set de value and label of default empty option:

Example:

<select name="estado" id="estado" empty-item-value="0" empty-item-label="- selecione -">
                    <options source="estados" />
                </select>

What do you think?

[Gregwar]

I think that the empty element should never be added by Formidable, this would let the user do whatever he wants Le dim. 5 mars 2017 20:23, Silas Ribas Martins <notifications@github.com> a écrit :

…

My idea Add attribute (not replicated as element attributes) flag (named as without-empty-item) that says: this hasn't a default empty option, without to use required attribute. But, if element is set as required, default empty option hasn't added like before. Example: <select name="estado" id="estado" without-empty-item> <option value="">- selecione -</option> <options source="estados" /> </select> OR add attributes to set de value and label of default empty option: Example: <select name="estado" id="estado" empty-item-value="0" empty-item-label="- selecione -"> <options source="estados" /> </select> What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWZruEi691GirC9dKv5ObJRt_2Rg8_9ks5rixmigaJpZM4MTTpG> .

[silasrm]

@Gregwar I agree with you :D

[Gregwar]

Ok, it's done, tell me if it's OK for you

[Gregwar]

Maybe I should make a new tag, like v1.1

[silasrm]

I'm glad with that solution. Thank you so much @Gregwar.

[silasrm]

@Gregwar you will make a new release?

[Gregwar]

I tagged master v1.1.0, so depending on * or 1.* should work now

[silasrm]

Many thanks @Gregwar :D