grub2-bhyve: Add -c, --cons-dev option to choose terminal #2
Conversation
This enables interactive GRUB menus, etc from users such as libvirt.
| @@ -272,6 +326,13 @@ grub_ncurses_init (struct grub_term_output *term __attribute__ ((unused))) | |||
| static grub_err_t | |||
| grub_ncurses_fini (struct grub_term_output *term __attribute__ ((unused))) | |||
| { | |||
|
|
|||
| #ifdef BHYVE | |||
There was a problem hiding this comment.
Should this block go after the endwin() call ? The curs_initscr(3X) man page states that delscreen should be called after endwin.
There was a problem hiding this comment.
The man page says this, but it also says delscreen releases memory while endwin resets the terminal. I have no idea if the order is important. I didn't see crashes or anything with the code as-is. I can dive into the curses implementation further if you want.
There was a problem hiding this comment.
The order may not matter, but having endwin() first matches the text of the man page's suggested tear-down sequence, and won't require any comments to explain to folk such as myself who look at the man page and then wonder why it's not in the same order :)
There was a problem hiding this comment.
Sure, feel free to reorder them :-).
There was a problem hiding this comment.
Just briefly looking at the ncurses code, it appears endwin() does do something with CURRENT_SCREEN; however, the delscreen() code does something that looks like resetting the current screen if the deleted screen is the current screen.
grub2-bhyve: Add -c, --cons-dev option to choose terminal
|
Thanks for the patch: this is extremely useful. I'll change the curses ordering in a follow-up commit. |
|
Thanks! libvirt support for this is in the works :-). |
This enables interactive GRUB menus, etc from users such as libvirt.