Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the quick start sample #324

Closed
wants to merge 1 commit into from
Closed

Adds the quick start sample #324

wants to merge 1 commit into from

Conversation

gremo
Copy link
Owner

@gremo gremo commented Apr 6, 2021

If you move the sample outside the project root it works, otherwise it doesn't:

nest-winston

@Nightbr
Copy link

Nightbr commented Apr 6, 2021

It works well
image

Here is what I have done:

cd sample/001-quick-start
npm install
npm start
npm run start:dev

You must cd in the example directory, it's an independent project from your lib ;)

@gremo
Copy link
Owner Author

gremo commented Apr 6, 2021

Yes that is what I did, but it doesn't work for me. Dunno why!

Can you please try to do first npm install in the project root and then cd sample/001-quick-start and npm run start:dev? I guess it's mocha and its types, conflicting with jest types.

nest-winston

@Nightbr
Copy link

Nightbr commented Apr 6, 2021

Ok got it,

you can add "skipLibCheck": true in sample/001-quick-start/tsconfig.json or you could refactor your Mocha tests into Jest tests (perhaps in another Issue/PR).

It's a conflict between Mocha & Jest Typing.

@gremo
Copy link
Owner Author

gremo commented Apr 6, 2021

@Nightbr setting skipLibCheck for every sample seems not right to me :)

Maybe take a look at #325 and feel free to improve it if you are confidenti with Jest, thanks!

@Nightbr
Copy link

Nightbr commented Apr 6, 2021

Yep sure SkipLibCheck is a workaround. But yes if you have the time to replace mocha by jest it's better 👌👍

I will take a look at #325 👌

@gremo
Copy link
Owner Author

gremo commented Apr 7, 2021

Closing in favor of #327

@gremo gremo closed this Apr 7, 2021
@gremo gremo deleted the sample-001-quick-start branch April 7, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants