New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable scope #670

Closed

andreacioni wants to merge 3 commits into gremo:main from andreacioni:configurable-scope

andreacioni commented May 24, 2023

Hello,

following discussion on issue #610 and #122 I tried to make a PR to address the need to have a configurable scope. I've also looked at #633 but I think the scope should be user defined and not changed to TRANSIENT by default.

Please let me know if tests and/or sample are also needed.

andreacioni added 3 commits

May 23, 2023 22:56


          add scope in loggerOpts

9c1d6fc


          add possibility to define a scope for Logger instances

a496b5c


          fix formatting

9dc2753

gremo force-pushed the master branch 9 times, most recently from c1465e5 to 8b3b51c Compare

June 26, 2023 10:30

Contributor

github-actions bot commented Aug 11, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions bot added the slate label

Author

andreacioni commented Aug 11, 2023

Still interested in merging this 😊. @gremo I can close it in case you believe is not necessary/useful.

github-actions bot removed the slate label

Contributor

github-actions bot commented Sep 26, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions bot added the slate label

Author

andreacioni commented Oct 1, 2023 •

edited

Loading

Preventing auto-close

github-actions bot removed the slate label

Contributor

github-actions bot commented Nov 16, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions bot added the slate label

sebastiendan commented Nov 22, 2023

Can we get this reviewed by a maintainer? This is a very important feature that's missing now, and the PR has been open for months. (thanks @andreacioni for doing this!)

github-actions bot removed the slate label

Contributor

github-actions bot commented Jan 7, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions bot added the slate label

github-actions bot removed the slate label

Contributor

github-actions bot commented Mar 1, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions bot added the slate label

Contributor

github-actions bot commented Mar 12, 2024

This PR was closed because it has been stalled for 10 days with no activity.

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment