Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

made nestLike output closer to nestjs #773

Merged
merged 1 commit into from Nov 22, 2023

Conversation

sezanzeb
Copy link
Contributor

@sezanzeb sezanzeb commented Nov 22, 2023

馃敡 Types of changes

Please explain the changes you made here.

Put an x in the boxes that apply (you can also fill these out after creating the PR).

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Codebase improvement
  • Other (if none of the other choices apply)

馃毃 Checklist

Your checklist for this pull request.

Put an x in the boxes that apply (you can also fill these out after creating the PR).

  • I've read the guidelines for contributing
  • I've added necessary documentation (if appropriate)
  • I've ensured that my code additions do not fail linting or unit tests (if applicable)

Description

This is how nestjs formats logs:

[Nest] 33476  - 11/22/2023, 10:19:55 AM     LOG [NestFactory] Starting Nest application...

this is how the format.nestLike option used to format logs:

[Nest] Info     11/22/2023, 11:27:24 AM [NestFactory] Starting Nest application...

this is how it formats it with the current change:

[Nest] 52605  - 11/22/2023, 11:31:43 AM     LOG [NestFactory] Starting Nest application...

which aligns perfectly now.

@gremo gremo merged commit cc863d5 into gremo:main Nov 22, 2023
@gremo
Copy link
Owner

gremo commented Nov 22, 2023

Thanks!

@sezanzeb
Copy link
Contributor Author

sezanzeb commented Nov 23, 2023

Oh, I overlooked that there was a tab in there

`${color(level.toUpperCase().padStart(7))}\t` +

There should be a space at the end instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants