Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.blank? isn't part of core ruby #1

Merged
merged 1 commit into from Jul 15, 2013
Merged

.blank? isn't part of core ruby #1

merged 1 commit into from Jul 15, 2013

Conversation

jimgreer
Copy link
Contributor

Currently this library uses String.blank? in a few places, which isn't part of core Ruby, and causes this error:

"foo".blank?
NoMethodError: undefined method `blank?' for "foo":String

I replaced it with the equivalent:

foo.nil? || foo.empty?

grempe added a commit that referenced this pull request Jul 15, 2013
.blank? isn't part of core ruby
@grempe grempe merged commit 343879f into grempe:master Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants