Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different Bytes lengths on == can still give True #48

Closed
lue-bird opened this issue Aug 9, 2022 · 2 comments · Fixed by #67
Closed

different Bytes lengths on == can still give True #48

lue-bird opened this issue Aug 9, 2022 · 2 comments · Fixed by #67

Comments

@lue-bird
Copy link

lue-bird commented Aug 9, 2022

In contrast to json Values, the documentation don't explicitly discourage calling == on Bytes, neither in

elm/bytes#15
The reason for this could again be, that, like for json values, the equal-check function only compares properties of the first argument. Here's one fix https://github.com/elm/core/pull/1092/files

@robinheghan robinheghan transferred this issue from gren-lang/bytes Dec 26, 2022
@blaix
Copy link
Contributor

blaix commented Mar 16, 2024

@robinheghan any objection to the fix linked in the description? This is affecting some cli work I'm doing so I'd be happy to test the fix and submit a PR if you think it looks good.

@robinheghan
Copy link
Contributor

robinheghan commented Mar 17, 2024

@blaix No objection to the fix.

blaix added a commit to blaix/gren-lang-core that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants