Implement same client cert check feature #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,3 +63,7 @@ Session.vim | |||
| *~ | |||
| # Auto-generated tag files | |||
| tags | |||
|
|
|||
| #IntelliJ | |||
There was a problem hiding this comment.
there is already existing IJ section at line 10. Merge your entries with it.
There was a problem hiding this comment.
Good catch ! Indeed this can be merged
| @@ -133,6 +133,7 @@ See: | |||
| --tls-client-key-password string Password to decrypt rsa private key | |||
| --tls-enable Whether or not to use TLS when connecting to the broker | |||
| --tls-insecure-skip-verify It controls whether a client verifies the server's certificate chain and host name | |||
| --same-client-cert-enable Use only when mutual TLS is enabled on proxy and broker. It controls whether a proxy validates if proxy client certificate matches brokers client cert (tls-client-cert-file) | |||
There was a problem hiding this comment.
should the flag start with "--tls"?
There was a problem hiding this comment.
- please change "matches" to "exactly matches" to avoid ambiguity.
- reorder sentences:
Controls whether a proxy validates if proxy client certificate exactly matches brokers client cert (tls-client-cert-file). Use only when mutual TLS is enabled on proxy and broker.
There was a problem hiding this comment.
I can do that, no problem
|
@mantkiewicz - thanks for comments, let's wait for @everesio review and then I will apply necessary changes in one go |
|
thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement same client cert check functionality as discussed in #37
Major changes: