Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It 2.0 #154

Merged
merged 16 commits into from
Jan 23, 2019
Merged

It 2.0 #154

merged 16 commits into from
Jan 23, 2019

Conversation

rmonroe
Copy link
Contributor

@rmonroe rmonroe commented Jan 18, 2019

This is a few of the bugs, so fuck around with alot of things to test.

  • Delete a course (with nested relations)
  • Disable a course
  • Moved members out of dropdown for ease of view
  • fixed Django vulnerability (run pip install -r requirements.txt)
  • course description in a container
  • if prof is a ta it will now show up in my courses
  • email recipients will add scroll when too many
  • Project cards will add ellipsis if to long for uniformity

@coveralls
Copy link

coveralls commented Jan 18, 2019

Coverage Status

Coverage decreased (-0.3%) to 37.058% when pulling 44f4c0f on IT_2.0 into 25f6398 on master.

@Kapn
Copy link
Member

Kapn commented Jan 18, 2019

ScrollTitle href link doesn't work, the css is never found since its looking at /course/test123/css/ScrollTitle.css etc which doesn't exist.
image
Needs to be changed to <link rel="stylesheet" href="{% static 'css/ScrollTitle.css' %}">

The course description container could probably be tweaked a bit but: 💯

Django update seems safe as far as not breaking anything else. We should update to latest version asap though (2.1.5).

I've been playing with the course disable. I think its working but the dashboard etc isn't displaying them correctly. Additionally I think the sidebar should only display Active courses (edit: I see now that there is an inactive course dropdown under My Courses, so under 'My Courses' are only active courses I assume), as I see the sidebar as a quick way to access frequently used courses. In the 'All Courses' view, we should display/allow filtering of Active/Disabled/All Courses. Currently my dashboard looks like:
image

Delete Course works like a charm 👍

Needs tests 🥴

Copy link
Member

@Kapn Kapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR Comment.

@rmonroe
Copy link
Contributor Author

rmonroe commented Jan 23, 2019

Testing

  • Delete course
  • disabling a course
  • get user active courses
  • get user inactive courses

- Deleted ScrollTitle
- Deleted migration 0007_..._0213
@Kapn Kapn merged commit 03da78c into master Jan 23, 2019
@Kapn
Copy link
Member

Kapn commented Jan 23, 2019

Fixed #77

@Kapn Kapn mentioned this pull request Jan 23, 2019
@Kapn Kapn deleted the IT_2.0 branch January 23, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants