Fix panics for blocks without update intervals #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammgws
added a commit
to ammgws/i3status-rust
that referenced
this pull request
May 15, 2020
This undoes the bandaid fixes that were implemented to deal with the panics that occur when only using blocks that have no update interval (ones that use DBus etc). Instead of kludging a dummy update interval to those blocks, the scheduler logic is changed so that no updates are scheduled if the block has no update_interval value set.
ammgws
added a commit
to ammgws/i3status-rust
that referenced
this pull request
May 15, 2020
This undoes the bandaid fixes that were implemented to deal with the panics that occur when only using blocks that have no update interval (ones that use DBus etc). Instead of kludging a dummy update interval to those blocks, the scheduler logic is changed so that no updates are scheduled if the block has no update_interval value set.
ammgws
added a commit
that referenced
this pull request
May 16, 2020
This undoes the bandaid fixes that were implemented to deal with the panics that occur when only using blocks that have no update interval (ones that use DBus etc). Instead of kludging a dummy update interval to those blocks, the scheduler logic is changed so that no updates are scheduled if the block has no update_interval value set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #535, but for the remaining blocks with the same issue.
Solves #581