Unify use of spawn_child_async in click handlers
#594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up greshake#530 by using `crate::subprocess::spawn_child_async` for all click handlers that spawn such processes, to unify handling of stdin and stdout and prevent broken pipe errors such as greshake#420 in all cases. This also uses spawns such commands with `sh -c` to making handling environment and quoting more flexible.
All uses of `subprocess::parse_command` were removed in b57d1dd.
|
LGTM Did you test it as well? |
|
Yes, I did — specifically the sound block as referenced in #420 but I also deliberately searched for and attempted to trigger the bug in other blocks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #530 by using
crate::subprocess::spawn_child_asyncforall click handlers that spawn such processes, to unify handling of stdin
and stdout and prevent broken pipe errors such as #420 in all cases.
This also uses spawns such commands with
sh -cto making handlingenvironment and quoting more flexible.