-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons option to Disk Space block #714
Conversation
Adds icons option to use hard disk icon instead of alias in the Disk Space block. Tested with FontAwesome4.
Maybe we could add a |
Sure, is there another block which has an example of this? |
Search blocks.md for "format", there are a few that could be used as a reference. |
Let me know if you need some help |
@ammgws done 🙂 I also made some changes to the way the alert state is triggered too, to allow for triggering on an absolute amount used, etc. |
@ammgws the only thing I dislike is that the 2 decimal places is hardcoded in, rather than being part of FormatTemplate, at the moment I see it only pushes the pre-formatted values matching keys: Line 434 in 735fc75
But maybe that could be extended to allow for stuff like |
I was also wondering if decimal control could be integrated into the format string. When thinking about things like the
or
|
@ammgws the above issues are fixed 🙂 |
What's going on with that diff for blocks.md? |
Oops, looks like it changed it to UNIX line endings, I can switch it back tonight, or we could just swap it to that like the rest of the files are. |
@ammgws so to confirm shall I switch it back to DOS line endings, or shall we just convert it to UNIX line endings like the rest of the files? |
Actually could you change it back for now? After this is merged submit another PR to fix the line endings. |
@ammgws done :) |
Thanks! |
Adds icons option to use hard disk icon instead of alias in the DiskSpace block.
Tested with FontAwesome4 (but I looked up glyph values for the others, to find comparable icons).
This is my first PR, please let me know if there is anything else to check!