-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kdeconnect block #717
Add kdeconnect block #717
Conversation
Works beautifully! Awesome idea :) Although personally, i don't really care about my phone's charge state (it always lasts the day) but only the notification count. Could we have the icon and state/color criteria changeable? The |
Yeah I'll change it so icons are specified via the format string instead, I think that should work. How should the state/colour work with notifications? Also does yours ever show anything but 0? |
Oh I think I forgot to add the handler for notifications. Oops! I'll do it sometime this week |
2edb495
to
db3c509
Compare
Updated.
I think that it should be OK to merge now as the basic functionality appears to be working fine. Probably need more people to test it anyway. |
b169f0f
to
9267629
Compare
Works great! Thanks!
This feels a little hacky but if it works ¯\_(ツ)_/¯. I'd recommend adding it to the block documentation as well though. |
Yeah it's what I went up with now since the other thing was to separate the block into widgets which would then mean multiple format strings are needed. IIRC other blocks with configurable state thresholds act similarly: if you set them all to 0 then block state won't be set at all. |
Ok yeah then that makes sense. I originally thought of another config option but that's probably way more bloat than necessary |
Ah I was waiting for that to come up. Is that when you start the bar before connecting your phone, or does it happen if you disconnect your phone after successfully starting the bar? Somehow I haven't managed to trigger it but I guess my VPN has kept it's connection this whole time. Edit: Actually going by that error message I think that one can only occur during startup. Maybe we can display a "disconnected" icon and then periodically check for it to come online. |
Well my usecase is that i take this computer lots of places, and only sometimes (at home) are both devices on the same subnet. At university, work, or a friend's place, either a) The network does not allow communication between devices or I only saw it while starting the computer+bar as of yet, but when i'm home i can test what happens when i disconnect the phone from wifi |
I turned my VPN and WiFi off before heading home and found that the bar was still alive, albeit the kdeconnect block was static with the last seen values. As soon as I connected my phone to the network the block updated again. Things to try:
|
Testers welcome!