-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format option to net block #738
Add format option to net block #738
Conversation
into develop-net-block-format-option
Might need to check the logic. Using this config on my wired desktop: [[block]]
block = "net" Get this: |
Confirming the error. Will look into it. |
Did you figure it out? |
I think 83a8311 fixed it. Is the issue still not resolved? |
Looks like, I did a silent commit and I didn't announce the update in the thread. |
Can you fix the blocks.md conflict? |
I think its done. |
I see that the last issue was relating to line endings. "\n" and "\r\n". Also we can do the following
|
They should all be Unix line endings. I fixed the conflict for now. |
fn format_vec_to_bar_graph<T> uses unicode chars.
Thanks! |
PR for the issue #692 .
The format option is added to the
net
block by this PR.If a user uses a deprecated option, the
format
option will not be used. This helps users into transitioning to the new options.