Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format option to net block #738

Merged
merged 12 commits into from
Jul 6, 2020

Conversation

gurditsbedi
Copy link
Contributor

PR for the issue #692 .
The format option is added to the net block by this PR.
If a user uses a deprecated option, the format option will not be used. This helps users into transitioning to the new options.

@gurditsbedi gurditsbedi changed the title Develop net block format option Add format option to net block Jun 13, 2020
@ammgws
Copy link
Collaborator

ammgws commented Jun 13, 2020

Might need to check the logic.

Using this config on my wired desktop:

[[block]]
block = "net"

Get this: Error in block 'net': Signal strength is only available for connected wireless devices.

@gurditsbedi
Copy link
Contributor Author

Confirming the error. Will look into it.

@remi-dupre remi-dupre mentioned this pull request Jun 18, 2020
4 tasks
@ammgws
Copy link
Collaborator

ammgws commented Jun 20, 2020

Did you figure it out?

@gurditsbedi
Copy link
Contributor Author

Did you figure it out?

I think 83a8311 fixed it. Is the issue still not resolved?

@gurditsbedi
Copy link
Contributor Author

Looks like, I did a silent commit and I didn't announce the update in the thread.

@ammgws
Copy link
Collaborator

ammgws commented Jun 29, 2020

Can you fix the blocks.md conflict?

@gurditsbedi
Copy link
Contributor Author

I think its done.
Sorry I am new to this, so I thought that the "merger to master" resolve the conflicts, that to for no reason at all.

@gurditsbedi
Copy link
Contributor Author

I see that the last issue was relating to line endings. "\n" and "\r\n".
I think we should decide upon the type of line ending to be used in the project.

Also we can do the following

  1. checking of line endings in the CI pipeline.
    OR
  2. add a git hook commit script.

@ammgws
Copy link
Collaborator

ammgws commented Jun 30, 2020

They should all be Unix line endings. I fixed the conflict for now.

src/util.rs Show resolved Hide resolved
src/blocks/net.rs Outdated Show resolved Hide resolved
@gurditsbedi gurditsbedi requested a review from ammgws July 4, 2020 12:10
@ammgws ammgws merged commit c9d5f3e into greshake:master Jul 6, 2020
@ammgws
Copy link
Collaborator

ammgws commented Jul 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[net block] add format option
2 participants