-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sed awk grep removal #758
Sed awk grep removal #758
Conversation
2b3d29f
to
4db9477
Compare
That's the remaining calls replaced. |
The fallback logic is broken. I only have
However the previous behaviour was that it didn't fail on |
7f286e4
to
761bbf0
Compare
Whoops, good spot. Should be fixed now. |
d9027b3
to
c567086
Compare
c567086
to
389f4bd
Compare
389f4bd
to
a9f7214
Compare
Hmm, current master and the below config works fine but pulling in this branch causes it to fail. It shouldn't fail since
|
OK I see what's going on. Before it would run, for example, `sh -c "ethtool ... | awk ..." and due to the command being piped to awk/sed/etc the exit code was 0 even if ethtool itself was not installed/failed to run. Now that all those pipes to sed/awk are gone and the command is called directly it is failing as it should have done before. |
Replace calls to sed, awk, grep, etc with the regex crate where possible.
Currently, don't have access to a machine with Wi-Fi, so those calls have been left in for now.
Closes #725