Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for valid nvidia_smi output #771

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

themadprofessor
Copy link
Contributor

When the nvidia driver is updated and the new module hasn't been loaded, nvidia-smi can produce invalid output such as "Failed to initialize NVML: Driver/library version mismatch", which can cause a panic.
This adds a check to ensure the output from nvidia-smi contains at least 2 commas.

@ammgws
Copy link
Collaborator

ammgws commented Jul 12, 2020

Is the exit status non-zero in that situation? Perhaps you could catch that instead.

@themadprofessor
Copy link
Contributor Author

That it does, shall change it to check for that.

@ammgws ammgws merged commit f3a302c into greshake:master Jul 13, 2020
@ammgws
Copy link
Collaborator

ammgws commented Jul 13, 2020

I don't have a way to test this so I hope it's OK.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants