Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter dynamic_width for music block #787

Merged
merged 2 commits into from
Aug 23, 2020
Merged

Add parameter dynamic_width for music block #787

merged 2 commits into from
Aug 23, 2020

Conversation

UnkwUsr
Copy link
Contributor

@UnkwUsr UnkwUsr commented Jul 31, 2020

By default, the music block has a static width (= max_width), and when the name of the music is too short, it looks very ugly: just unnecessary free space inside the bar.

When dynamic_width is set to true and the name of the music is longer than max_width, block width will be set to max_width (marquee option remains available), but when name is less than max_width, block width will be set equal to the name of the music, so no free space left.
P.S. I have the music block in the first place (counting from the left), so dynamic width looks very cool. But if people have it in the middle or at the end, then music block will affect next blocks after music and jumpy text can be annoying, so we have this behavior as a config parameter.

Possible resolves #780

@Alexeyan
Copy link

+1 from me. Would like this feature.

@ammgws
Copy link
Collaborator

ammgws commented Aug 23, 2020

Seems OK to me.

@ammgws ammgws merged commit 48ba529 into greshake:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_width behaving like min_width on music block
3 participants