Add parameter dynamic_width for music block #787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the music block has a static width (=
max_width
), and when the name of the music is too short, it looks very ugly: just unnecessary free space inside the bar.When
dynamic_width
is set to true and the name of the music is longer thanmax_width
, block width will be set tomax_width
(marquee option remains available), but when name is less thanmax_width
, block width will be set equal to the name of the music, so no free space left.P.S. I have the music block in the first place (counting from the left), so dynamic width looks very cool. But if people have it in the middle or at the end, then music block will affect next blocks after music and jumpy text can be annoying, so we have this behavior as a config parameter.
Possible resolves #780