Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time block: support locales #863

Merged
merged 1 commit into from
Oct 14, 2020
Merged

time block: support locales #863

merged 1 commit into from
Oct 14, 2020

Conversation

ammgws
Copy link
Collaborator

@ammgws ammgws commented Oct 14, 2020 •
edited

Resolves #73 via a new config option.

test config

[[block]]
block = "time"

[[block]]
block = "time"
locale = "fr_BE"
timezone = "US/Pacific"

output

{"version": 1, "click_events": true}
[[{"background":"#000000","color":"#a9a9a9","full_text":"| ","markup":"pango","separator":false,"separator_block_width":0},{"background":"#000000","color":"#93a1a1","full_text":" Wed 14/10 11:35 ","markup":"pango","name":"e97f48901fa4434daf67d4fbf94c0480","separator":false,"separator_block_width":0},{"background":"#000000","color":"#a9a9a9","full_text":"| ","markup":"pango","separator":false,"separator_block_width":0},{"background":"#000000FF","color":"#93A1A1FF","full_text":" mar 13/10 19:35 ","markup":"pango","name":"a874badad8a14e6bbf1f49cc22347db9","separator":false,"separator_block_width":0}],

TODO

  • retrieve LC_TIME from env var or from the output of locale
  • refactor code
  • deserialisation support for Locale

@ammgws ammgws closed this Oct 14, 2020
@ammgws ammgws reopened this Oct 14, 2020
@ammgws ammgws mentioned this pull request Oct 14, 2020
Closed
@ammgws
time block: support locales
66ed368 
Resolves greshake#73 via a new config option.

TODO

    retrieve LC_TIME from env var or from the output of locale
    refactor code
    deserialisation support for Locale
@ammgws ammgws merged commit 9b2b60a into greshake:master Oct 14, 2020
@ammgws ammgws deleted the locale branch October 14, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time module does not respect locale
1 participant
@ammgws