Fix net block hiding issue

[GladOSkar]

Fix net block issue where both hide_inactive and hide_missing had to be enabled to ever hide the block on either case. (#891)

This PR implements the functionality as i would expect it:

• active = !exists || !up
• show full block if active
• hide block if inactive && hide_inactive || !exists && hide_missing
• otherwise, show only icon

I tested all cases and it works as described.

Does that sound correct to you, @ammgws @mvdan ?

[ammgws]

Maybe better rewritten as:

let self.exists = self.device.exists()?;
let self.active = self.device.is_up()?;
if !self.exists || !self.active {
...

?

[GladOSkar]

Alright, i did it a little differently than you suggested because it's even cleaner to clarify that active always implies exists

[ammgws]

LGTM, now hide_missing actually does what it was supposed to do.

Can you update the docs to be more clear? For example, clarifying that "missing" means the device does not exist on the system.

[GladOSkar]

Alright i updated the block docs and rewrote the logic there a bit

[GladOSkar]

No idea why the CI check is failing :/

[ammgws]

Just need to run rustfmt, but otherwise it builds fine locally.

Thanks!