Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alternating tint logic when blocks are hidden #924

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

ammgws
Copy link
Collaborator

@ammgws ammgws commented Nov 11, 2020

Fixes #349

@GladOSkar would you like to give it a go and see if it's fixed? Testing with the below config showed the colours match the current behaviour so I assume it's working:

[theme]
name = "slick"
[theme.overrides]
separator = "SEPARATOR"

[icons]
name = "awesome"

[[block]]
block = "time"

[[block]]
block = "time"

[[block]]
block = "time"

[[block]]
block = "time"

@GladOSkar
Copy link
Contributor

Yes it works beautifully, thank you!

@GladOSkar
Copy link
Contributor

I wonder if it would make more sense to do the alternating from right to left than from left to right, since the right is basically the anchor of the status bar.

Currently, whenever a network device shows up or disappears on my system, the alternating color stays the same on the left of that block and flips on the right. I'd rather have it the other way around

@ammgws ammgws merged commit f864c0b into greshake:master Nov 11, 2020
@ammgws ammgws deleted the alternator branch November 11, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide_missing looks weird with alternating color scheme
2 participants