net block: do not error out when arrays are empty #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Malformed JSON" doesn't make sense as an error since if the JSON itself was invalid then serde would catch it earlier. We will trust that `ip` is outputting a valid response, and if that response contains no ip address info then we can just return None instead of erroring out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Malformed JSON" doesn't make sense as an error since if the JSON itself was
invalid then serde would catch it earlier. We will trust that
ipis outputtinga valid response, and if that response contains no ip address info then we can
just return None instead of erroring out.