Layout + tinting rework #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GladOSkar
force-pushed
the
layout-tint-rework
branch
2 times, most recently
from
e9c72e3
to
c8228c3
Compare
ammgws
reviewed
Nov 11, 2020
|
There ya go |
GladOSkar
force-pushed
the
layout-tint-rework
branch
from
b2d90e8
to
7a599ff
Compare
GladOSkar
force-pushed
the
layout-tint-rework
branch
from
7a599ff
to
da1658d
Compare
|
Thanks for adding the comments as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #925
I restructured and cleaned up a lot which turned out not to be necessary for the final solution but might be nice anyways. I don't think i introduced any regressions but that should be tested.
Alternating tint is now anchored to the right by counting the visible blocks beforehand and starting the alternating sequence accordingly on the left.
I barely have any rust experience, please lmk if something could be done better :)