Bugfix on generation, RC2 prep (#41)

* Bugfix on generation, RC2 prep * Use SCM for install Co-authored-by: John Myers <john@gretel.ai>
gretelai · Aug 4, 2020 · f7cf83b · f7cf83b
1 parent deb22ec
commit f7cf83b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/VERSION b/VERSION
diff --git a/setup.py b/setup.py
@@ -6,13 +6,14 @@
 with open(path.join(this_dir, 'README.md'), encoding='utf-8') as f:
     long_description = f.read()
 
-with open(path.join(this_dir, 'VERSION')) as f:
-    version = f.read()
+# with open(path.join(this_dir, 'VERSION')) as f:
+#    version = f.read()
 
 
 setup(
     name='gretel-synthetics',
-    version=version,
+    use_scm_version=True,
+    setup_requires=["setuptools_scm"],
     description='Synthetic Data Generation with optional Differential Privacy',
     long_description=long_description,
     long_description_content_type='text/markdown',

diff --git a/src/gretel_synthetics/generator.py b/src/gretel_synthetics/generator.py
@@ -179,7 +179,9 @@ def generate_next(self, num_lines: int) -> Iterable[gen_text]:
                         _valid = True
                     yield gen_text(text=rec, valid=_valid, explain=None, delimiter=self.delim)
             except Exception as err:
-                # logging.warning(f'Line failed validation: {rec} errored with {str(err)}')
+                # NOTE: this catches any exception raised by the line validator, which
+                # also creates an invalid record
+                lines_generated += 1
                 self.total_invalid += 1
                 yield gen_text(text=rec, valid=False, explain=str(err), delimiter=self.delim)
             else: