switch/select type dynamically #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch/select type dynamically
|
I like the changes here but it decreases test coverage. Could you write some tests to cover the changes you made? Thanks! |
1) added setStorageType(type) 2) added type to relevant calls except removeFromLocalStorage(...), as it's a vararg variety, but easy to do if needed. This is a non-intrusive patch, as it preserves original functionality with minimal changes, but adds storage type selectability when needed. Typical use case: your existing code picked one type as default, but in a couple of places you need to use the other type, then try this: setStorageType(non-default-type); // switch to new type ...do your storage calls setStorageType(default-type); // restore default Or you can specify a type to each call directly (without type specified, will use whatever the last type active).
removeFromLocalStorage() supports selecting storage type as the last parameter. not as optimized as I'd like for the patches, but they're non-invasive, and easy to reason for correctness. This completes the type selection patch (TODO: need to add tests).
removeFromLocalStorage() to take type param
|
Thanks. |
|
This should be documented in the readme to let people know it is possible. |
|
Not sure this was the best implementation - why, when specified in the call directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-intrusive patch, as it preserves original functionality with minimal changes, but adds storage type selectability when needed.
Typical use case:
your existing code picked one type as default, but in a couple of places you need to use the other type, then try this:
setStorageType(non-default-type); // switch to new type
...do your storage calls
setStorageType(default-type); // restore default
Or you can specify a type to each call directly (without type specified, will use whatever the last type active).