Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Expr for default values instead of TokenStream #71

Closed
greyblake opened this issue Jul 22, 2023 · 0 comments · Fixed by #72
Closed

Use Expr for default values instead of TokenStream #71

greyblake opened this issue Jul 22, 2023 · 0 comments · Fixed by #72
Assignees
@greyblake
Labels
Ready Can be taken for implementation without any potential blockers refactoring Inner library changes to improve maintainance v0.4.0 Issue for the next major release (0.4.0)

Comments

@greyblake
Copy link
Owner

greyblake commented Jul 22, 2023 •
edited

Context

Currently we use maybe_default_value: Option<TokenStream> to keep the value of default attribute.

Specs

  • Use syn::Expr instead of TokenStream to keep the value of default attribute

Acceptance Criteria

All the current tests pass without changes.
@greyblake greyblake self-assigned this Jul 22, 2023
@greyblake greyblake added refactoring Inner library changes to improve maintainance v0.4.0 Issue for the next major release (0.4.0) Ready Can be taken for implementation without any potential blockers labels Jul 22, 2023
@greyblake greyblake mentioned this issue Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greyblake greyblake

Labels
Ready Can be taken for implementation without any potential blockers refactoring Inner library changes to improve maintainance v0.4.0 Issue for the next major release (0.4.0)
Projects
No open projects
Nutype v0.4.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use syn::Expr for defualt attribute greyblake/nutype
1 participant
@greyblake