Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'test_specified_fields' to check for reverse_accessor fields #15

Closed
wants to merge 4 commits into from

Conversation

jnoortheen
Copy link

in my case, I has reverse accessor field in the search_fields attribute of the ModelAdmin. But the test_specified_fields method is not checking that fields. I've added that checks.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling c9b3f8d on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ca14752 on jnoortheen:master into ** on greyside:master**.

4 similar comments
@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling ca14752 on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling ca14752 on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling ca14752 on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Changes Unknown when pulling ca14752 on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Changes Unknown when pulling 166fffd on jnoortheen:master into ** on greyside:master**.

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Changes Unknown when pulling 166fffd on jnoortheen:master into ** on greyside:master**.

@PetrDlouhy
Copy link
Contributor

This fixes checking of reverse accessor field problem for me.
But the PR contains some changes, that shouldn't be pulled to the main repository:

  • Change of PyPI identifier
  • Change of README
  • Fabfile with release script (I would i.e. use bumpversion for part of this).

So I would advise some changes in order to get this pulled:

  • Rebase to current HEAD and fix tests (if the rebase itself doesn't help)
  • Make test for the fix
  • Separate the Fabfile to another PR and discuss that change there

@jnoortheen
Copy link
Author

It is my mistake. Since there was no activity I updated a PyPI version myself. Since the master branch was directly referred, the changes got it here. I will update it.

@jnoortheen
Copy link
Author

I am closing PR and creating another one

@jnoortheen jnoortheen closed this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants