Fix the default prediction.type in survival predict
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikcs
added a commit
to erikcs/grf
that referenced
this pull request
Jun 12, 2020
* master: Correct the generated documentation for `best_linear_projection` (grf-labs#689) Fix the default `prediction.type` in survival predict (grf-labs#686) Add optional Nelson-Aalen estimates of the survival function (grf-labs#685) Clarify the survival forest prediction documentation (grf-labs#681) Prepare the 1.2.0 release (grf-labs#679) Add survival/quantile/local linear timings to benchmark script (grf-labs#680) Fix punctuation. (grf-labs#677) Update references in README (grf-labs#676) README: add the grant number to ONR (grf-labs#675) Add an acknowledgements section to README (grf-labs#674) Remove passing explicit default options to `findInterval()` (grf-labs#673) Add option to predict at chosen failure times (grf-labs#672) Simplify some R build options in Travis (grf-labs#670) Make consistent use of logical operators in R bindings (grf-labs#669) Predict with training quantiles by default (grf-labs#668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minor fix to #685 where we mistakingly predict with Kaplan-Meier by default, instead of the
prediction.typethe forest was trained with by default.