Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceRender does not return "No records found" if data is empty #1360

Closed
exiao opened this issue Jun 9, 2023 · 2 comments
Closed

ForceRender does not return "No records found" if data is empty #1360

exiao opened this issue Jun 9, 2023 · 2 comments
Labels
wontfix This will not be worked on

Comments

@exiao
Copy link

exiao commented Jun 9, 2023

Describe the bug
Use the search function to search for gibberish and see the table return just the header with no string message for an empty table.

If you forceRender a table with data as an empty list, you will also get this bug.

To Reproduce

  1. Go to https://gridjs.io/docs/examples/force-render
  2. Search for gibberish or anything that doesn't match the table
  3. See the results with no NoRecordsFound error.

Expected behavior
No results found should appear

Screenshots
CleanShot 2023-06-09 at 16 29 09@2x

Code area which is not working
https://github.com/grid-js/gridjs/blob/master/src/view/table/tbody.tsx

@stale
Copy link

stale bot commented Aug 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 10, 2023
@stale stale bot closed this as completed Sep 17, 2023
@hoangnt2
Copy link

Facing same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants