Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Neuman and Robin boundary conditions #29

Closed
fverdugo opened this issue Jun 5, 2019 · 5 comments
Closed

Add support for Neuman and Robin boundary conditions #29

fverdugo opened this issue Jun 5, 2019 · 5 comments

Comments

@fverdugo
Copy link
Member

fverdugo commented Jun 5, 2019

This basic functionality is still to be implemented

Work being done in branch surface_integration

@fverdugo
Copy link
Member Author

fverdugo commented Jun 14, 2019

In order to do this work, we need the new functionality that will be available after the ongoing re-factoring of CellValues (see issue #30).

In particular, we need that indexable cell values, remain indexable after operations with them. (Now, operations always return iterable CellValues) .

We also need to "reindex" indexable CellValues, e.g., to restrict a CellValue to a sub-set of its indices

EDIT: This has been done in PR #31

@fverdugo
Copy link
Member Author

fverdugo commented Jul 3, 2019

After commit e981f3c we can restrict CellFields and CellBasis objects to surfaces. However, some things need to be optimized and enhanced:

  • We need to efficiently implement reindex for cell fields arising from applying kernels. Be carefull with objects resulting from applying the gradient. Done it commit 952359e
  • Extend to non oriented faces For Neuman and Robin BCs this is not needed. It will be required to integrate in the skeleton.
  • FullGridGraph not strictly needed for building a BoundaryGrid. Item moved to its own issue FullGridGraph not strictly needed in some places #44
  • Make FEFunction indexable, and implement an efficient version of restrict for it. Done in commit ca77bb3

@fverdugo
Copy link
Member Author

First example with Neumann BCs in commit 4dcd16f

We do not close the issue until we test Robin conditions and improve the implementation of reindex

@fverdugo
Copy link
Member Author

First example with Robin BCs in commit 946054a

@fverdugo
Copy link
Member Author

This work has finished with commit 952359e

The only missing part is moved to a separate issue (issue #44)

Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant