Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in compute_face_nodes() for CartesianDiscreteModels #873

Open
JordiManyer opened this issue Feb 9, 2023 · 0 comments
Open

Bug in compute_face_nodes() for CartesianDiscreteModels #873

JordiManyer opened this issue Feb 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JordiManyer
Copy link
Member

Not very important, but compute_face_nodes fails for CartesianDiscreteModels.

Code to reproduce:

D = 2
domain = Tuple(repeat([0,1],D))
cmodel = CartesianDiscreteModel(domain,Tuple(fill(2,D)))
compute_face_nodes(cmodel)

Error:

julia> compute_face_nodes(cmodel)
ERROR: MethodError: no method matching append_tables_globally(::Gridap.Arrays.Table{Int32, Vector{Int32}, Vector{Int32}}, ::Gridap.Arrays.Table{Int32, Vector{Int32}, Vector{Int32}}, ::Gridap.Geometry.CartesianCellNodes{2})
Closest candidates are:
  append_tables_globally(::Gridap.Arrays.Table{T, Vd, Vp}...) where {T, Vd, Vp} at ~/Documents/Gridap.jl/src/Arrays/Tables.jl:231
Stacktrace:
 [1] compute_face_nodes(model::CartesianDiscreteModel{2, Float64, typeof(identity)})
   @ Gridap.Geometry ~/Documents/Gridap.jl/src/Geometry/DiscreteModels.jl:180
 [2] top-level scope
   @ REPL[29]:1

The issue is that append_tables_globally expects only Tables, while compute_face_nodes(cmodel,Dc) returns a Gridap.Geometry.CartesianCellNodes (which is also <: AbstractVector{<:Vector{T}} but not a Table).

@JordiManyer JordiManyer added the bug Something isn't working label Feb 9, 2023
shagun751 added a commit to shagunTUD/Gridap.jl that referenced this issue Feb 21, 2023
@JordiManyer JordiManyer linked a pull request Jan 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant