Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not passing with FillArrays@0.13.9 #889

Closed
JordiManyer opened this issue Mar 21, 2023 · 3 comments
Closed

Tests are not passing with FillArrays@0.13.9 #889

JordiManyer opened this issue Mar 21, 2023 · 3 comments
Assignees

Comments

@JordiManyer
Copy link
Member

This has been happening in new PRs (#888 , #886 ): CI is not passing very early on.

After some testing, I am sure it's because of broadcasting for FillArrays. Tests are ok with version v0.13.7 but fail for v0.13.9.

Error benchmark:

using FillArrays
using Test

a = Fill(ones(3,3),4)
a + a      # This fails!
a .+ a     # This is fine!

The line that fails works for v0.13.7.

I am not sure if this is the desired behavior, but it seems to be the behavior now.
Should I open an issue in FillArrays, or just fix our tests?

@oriolcg @amartinhuertas @fverdugo

@JordiManyer JordiManyer self-assigned this Mar 21, 2023
@amartinhuertas
Copy link
Member

I would first add an issue in FillArrays to get an answer from them in regards to whether this is desired behaviour or a BUG.

@JordiManyer
Copy link
Member Author

There is an issue in FillArrays already, I just wrote a comment. Let's see, I'll try to stay on top of it.

@JordiManyer
Copy link
Member Author

This has been solved in FillArrays v0.13.10, tests seem to be passing now. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants