Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.13.8 breakage #224

Closed
theogf opened this issue Mar 21, 2023 · 5 comments
Closed

0.13.8 breakage #224

theogf opened this issue Mar 21, 2023 · 5 comments

Comments

@theogf
Copy link

theogf commented Mar 21, 2023 •
edited
Loading

The 0.13.8 release broke this basic MWE...

x = rand(3, 3)
X = Fill(x, 10)
X + X
ERROR: DimensionMismatch: arrays could not be broadcast to a common size; got a dimension with lengths 10 and 3

This comes from the new fill_add using broadcasting for some reason that escapes me.

[EDIT:] Corrected code snippet
@theogf theogf mentioned this issue Mar 21, 2023
Merged
5 tasks
@jishnub
Copy link
Member

jishnub commented Mar 21, 2023

Perhaps these methods need to be limited to Fill with numeric eltypes

@JordiManyer
Copy link

Same issue in Gridap.jl

Is this a feature or a bug?

@jishnub
Copy link
Member

jishnub commented Mar 22, 2023

Definitely a bug @putianyi889

@putianyi889
Copy link
Contributor

no need to limit eltype. I'll fix it.

@putianyi889
Copy link
Contributor

For a quick fix, use X .+ X.

putianyi889 added a commit to putianyi889/FillArrays.jl that referenced this issue Mar 22, 2023
@putianyi889
fix JuliaArrays#224
9c2c153
@putianyi889 putianyi889 mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jishnub @theogf @JordiManyer @putianyi889