Odes cache system at initial time #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 172 172
Lines 20037 20037
=======================================
Hits 17749 17749
Misses 2288 2288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oriolcg
approved these changes
Mar 27, 2023
|
Hi @ericneiva ! Thanks for the changes. Can you please edit the README.md file? |
I guess you meant the NEWS.md file @amartinhuertas. It's done! Thank you @amartinhuertas and @oriolcg! |
…system_at_initial_time
…/Gridap.jl into odes_cache_system_at_initial_time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
If the ODEOperator is Constant or Affine, matrix and vector are allocated at the initial time.
If the ODEOperator is NonLinear, matrix and vector are allocated at the time stored by the operator (because there is no access to the initial time step).
@oriolcg, would you take a look at this whenever you have some time?