Implementing Explicit Runge Kutta Methods #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tamaratambyah can you please modify You have to add the new feature (explicit RK) in the unreleased part. |
|
@tamaratambyah the ODE tests are not passing. Can you please check try to fix the errors? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 88.17% 88.08% -0.10%
==========================================
Files 176 177 +1
Lines 20936 21053 +117
==========================================
+ Hits 18460 18544 +84
- Misses 2476 2509 +33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean version of PR#951 for explicit Runge Kutta.
In this PR, I have implemented multi-stage, explicit Runge Kutta method in EXRungeKutta.jl. This follows the format and structure of RungeKutta.jl and IMEXRungeKutta.jl.
I have added an additional operator TransientEXRungeKuttaFEOperator. However, I think this can be combined with TransientRungeKuttaFEOperator to have one operator which works for both explicit and diagonally implicit Runge Kutta (IMEX will probably still require its own operator).
@santiagobadia can you please review this PR
Thanks