-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Explicit Runge Kutta Methods #952
Conversation
@tamaratambyah can you please modify You have to add the new feature (explicit RK) in the unreleased part. |
@tamaratambyah the ODE tests are not passing. Can you please check try to fix the errors? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 88.17% 88.08% -0.10%
==========================================
Files 176 177 +1
Lines 20936 21053 +117
==========================================
+ Hits 18460 18544 +84
- Misses 2476 2509 +33 ☔ View full report in Codecov by Sentry. |
This is a clean version of PR#951 for explicit Runge Kutta.
In this PR, I have implemented multi-stage, explicit Runge Kutta method in EXRungeKutta.jl. This follows the format and structure of RungeKutta.jl and IMEXRungeKutta.jl.
I have added an additional operator TransientEXRungeKuttaFEOperator. However, I think this can be combined with TransientRungeKuttaFEOperator to have one operator which works for both explicit and diagonally implicit Runge Kutta (IMEX will probably still require its own operator).
@santiagobadia can you please review this PR
Thanks