New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paur task1 #18
Paur task1 #18
Conversation
Clean-up of the module and first tests.
Visualize a Grid() or UnstructuredGrid() using mesh and wireframe from Makie.
Add nodaldata and colormap. Send .DS_Store to .gitignore.
Extension of wireframe function to fit quad meshes. Addition of colormap and colorbar in the tests.
Added a couple of lines in the conversion in 3D: the connectivity cns is converted via SimplexFace{D+1,Type} instead of NgonFace{D+1,Type} since the latter creates quads in 3D. Also, Makie.mesh does not support the type tetrahedron, so the grid is converted with normal_mesh.
Codecov Report
@@ Coverage Diff @@
## gsoc2021-master #18 +/- ##
==================================================
Coverage ? 94.11%
==================================================
Files ? 1
Lines ? 34
Branches ? 0
==================================================
Hits ? 32
Misses ? 2
Partials ? 0 Continue to review full report at Codecov.
|
@paurierap I have refactored the conversions significanly. The goal of this refactoring is:
function to_plot_mesh(grid::UnstructuredGrid)
if num_cell_dims(grid) == 3
grid |> to_boundary_grid |> to_simplex_grid |> to_mesh |> GeometryBasics.normal_mesh
else
grid |> to_simplex_grid |> to_mesh
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This compleates all tasks in #16.
Merged! @paurierap I have deleted the Plase create a new branch |
To describe ... @ericneiva @fverdugo @paurierap involved
Related to #16