Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to current Makie version #56

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Conversation

JonasIsensee
Copy link

@JonasIsensee JonasIsensee commented Jul 11, 2022

This PR updates the version bounds and adds the missing definition to enable compatibility to the latest Makie release.

this supersedes all the other compat PRs

closes #38 #44 #46 #47 #48 #49 #53 #54 #55

@codecov-commenter
Copy link

Codecov Report

Merging #56 (7b0be96) into master (0e9bcf6) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   93.06%   93.13%   +0.06%     
==========================================
  Files           2        2              
  Lines         202      204       +2     
==========================================
+ Hits          188      190       +2     
  Misses         14       14              
Impacted Files Coverage Δ
src/conversions.jl 92.12% <ø> (ø)
src/recipes.jl 94.80% <ø> (+0.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fverdugo fverdugo merged commit 3b9fc0e into gridap:master Jul 19, 2022
@fverdugo
Copy link
Member

Thanks for this @JonasIsensee

@JonasIsensee JonasIsensee mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants