Removed PolynomialMapCubedSphereDiscreteModel and PolynomialMapCubedSphereTriangulation types. #35
Conversation
PolynomialMapCubedSphereTriangulation types. They are not actually needed. We can provide the same functionality using Gridap types.
|
Hi @amartinhuertas , is this PR going to effect the use of GridapHybrid on the cubed sphere? |
Hi @davelee2804 ! I was revisiting the data structures for CubedSphere meshing (towards refreshing what we did) and I realized that there are two types which are just wrappers of Gridap types. Thus, we can eliminate them. This does not solve per-se the current problem we have with GridapHybrid on the cubed sphere. |
|
Thanks for the confirmation @amartinhuertas |
|
For the records, MPI tests are failing. https://github.com/gridapapps/GridapGeosciences.jl/runs/7143096336?check_suite_focus=true#step:9:102 However, I realized that exactly the same error is in the hdg_adv branch. https://github.com/gridapapps/GridapGeosciences.jl/runs/7129780507?check_suite_focus=true#step:9:102 Thus, the changes introduced in this PR seem to be inocent for this failing tests. |
|
For the records, the following commit in main might circumvent (temporarily) the failing MPI Tests 7cf147e |
|
Ok, sequential tests pass. This seems to confirm that the two data structures I have eliminated in this PR are not actually needed. |
|
Thanks @amartinhuertas , I'll pull that in... |
…nto refactoring_cubed_sphere_data_structures
Let us see if the tests pass first in this branch. We have to pull that in the ADV-HDG branch with care. There might be conflicts. I can do it, no worries. |
|
OK, thanks Alberto! |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 18 18
Lines 1258 1246 -12
======================================
+ Misses 1258 1246 -12
Continue to review full report at Codecov.
|
They are not actually needed. We can provide the same functionality using Gridap types.