Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes for OpenSSL-3.0.0-beta1 #157

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Add fixes for OpenSSL-3.0.0-beta1 #157

merged 1 commit into from
Jul 20, 2021

Conversation

msalle
Copy link
Member

@msalle msalle commented Jun 28, 2021

A few small changes make the GCT build against OpenSSL-3.0.0-beta1. I've tested some parts run-time.

  • several function parameters are now const
  • CRYPTO_mem_ctrl() (together with several others) is deprecated and by default no longer available, unless OpenSSL is configured using enable-crypto-mdebug

@msalle
Add fixes for OpenSSL-3.0.0-beta1
1f0fd69 
- several function parameters are now const
- CRYPTO_mem_ctrl() (together with several others) is deprecated and by default
  no longer available, unless OpenSSL is configured using enable-crypto-mdebug
fscheiner
fscheiner approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@fscheiner fscheiner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have a few questions below.

Let's merge this after #155.

gsi/gssapi/source/test/gssapi_anonymous_test.c Show resolved Hide resolved
gsi/proxy/proxy_core/source/library/globus_gsi_proxy.c Show resolved Hide resolved
gsi/proxy/proxy_ssl/source/library/proxycertinfo.h Show resolved Hide resolved
gsi/proxy/proxy_ssl/source/library/proxypolicy.h Show resolved Hide resolved
@fscheiner
Copy link
Member

@msalle @matyasselmeci @ellert:
BTW, is it only me or do others also find that OpenSSL 3.0 reminds one of the unsecure SSL version 3?

@maarten-litmaath
Copy link

Yeah, they should have gone straight to v4 instead... :-)

@fscheiner
Copy link
Member

Indeed, there is a reason why Microsoft went straight to 10 from 8.1 - nobody wanted to see a Windows 9.5 or 9.8.

Anyone knows why OpenSSL developers didn't use 2.0? Is 2.0 an unlucky number (for them)?

@msalle
Copy link
Member Author

msalle commented Jul 9, 2021

Indeed, there is a reason why Microsoft went straight to 10 from 8.1 - nobody wanted to see a Windows 9.5 or 9.8.

Anyone knows why OpenSSL developers didn't use 2.0? Is 2.0 an unlucky number (for them)?

See The Holy Hand Grenade of Antioch (-;

@fscheiner
Copy link
Member

See The Holy Hand Grenade of Antioch (-;

Thanks for that. The next article there explains why it's OpenSSL and not OpenTLS.

@fscheiner fscheiner mentioned this pull request Jul 15, 2021
Merged
@fscheiner
Copy link
Member

#155 is in, so I'm gonna merge this one now.

@fscheiner fscheiner merged commit 951c99e into gridcf:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fscheiner fscheiner fscheiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msalle @fscheiner @maarten-litmaath