Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More OpenSSL3.0 fixes, for 3.0-beta2 #159

Merged
merged 2 commits into from Aug 16, 2021

Conversation

msalle
Copy link
Member

@msalle msalle commented Aug 8, 2021

OpenSSL 3.0 beta2 has removed a few functions:

  • ERR_GET_FUNC() is no longer there and there is no simple replacement, so we best just comment out the one place it occurs.
  • gsi_openssh (which we now include) uses FIPS_mode() which no longer exists in 3.0. Also here there is no easy replacement, since FIPS mode is quite differently enabled in 3.0. We add a macro via the new fips_mode_replacement.h that simply returns 0.

- ERR_GET_FUNC() is no longer there and there is no simple replacement.
- gsi_openssh uses FIPS_mode() which no longer exists. Also there there is no
  easy replacement, since FIPS mode is quite differently enabled in 3.0. We add
  a macro via fips_mode_replacement.h that simply returns 0.
@fscheiner
Copy link
Member

@msalle
Please, when rebasing your commits or adding additional commits to this PR, cancel the Travis CI builds as soon as possible. If you can't do that yourself, please wait until we had our next release in week 33 with further changes here. This to save credits.

@msalle
Copy link
Member Author

msalle commented Aug 9, 2021

Ok will do. I don't plan to change anything, nor to open any more PR.
OpenSSL 3.0 beta2 is hopefully the last beta, at least that's what's OpenSSL's plan. Also this adds the stuff needed for gsi-openssh which wasn't there when I tried the last time. I thought it would be silly to have a half-fixes version when we bring our a release soon.
Not sure actually whether I can cancel a Travis run.

@fscheiner
Copy link
Member

Ok will do. I don't plan to change anything, nor to open any more PR.
OpenSSL 3.0 beta2 is hopefully the last beta, at least that's what's OpenSSL's plan. Also this adds the stuff needed for gsi-openssh which wasn't there when I tried the last time. I thought it would be silly to have a half-fixes version when we bring our a release soon.

I fully agree. And we only have a problem because we're running out of credits on Travis CI. In the future our build tests are going to be moved over to GitHub Actions and we might build on noncharged architectures over at Travis CI to ease that, @matyasselmeci will make sure of that.

@fscheiner
Copy link
Member

@fscheiner
Copy link
Member

@ellert:
Just to be sure: As files from "gsi_openssh" are changed by this PR, too, should we also change the GSI-OpenSSH version in gsi_openssh/version.m4 in some way? Currently we have 8.6p1c. BTW, what's the c for in this version string?

@msalle

@fscheiner wrote:
Please, when rebasing your commits or adding additional commits to this PR, cancel the Travis CI builds as soon as possible. If you can't do that yourself, please wait until we had our next release in week 33 with further changes here. This to save credits.

Not sure actually whether I can cancel a Travis run.

I think it should work, as you are a member of our gridcf organization.

@fscheiner
Copy link
Member

I'm merging this now and will afterwards create a tag for our next release candidate of the GCT.

@fscheiner fscheiner merged commit 246f1c3 into gridcf:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants