Fix some compiler and doxygen warnings

[ellert]

This PR addresses the following compiler and doxygen warnings:

globus-authz

authz_cred_test.c:68:41: warning: unused variable 'request_object' [-Wunused-variable]
authz_cred_test.c:67:41: warning: unused variable 'request_action' [-Wunused-variable]
authz_cred_test.c:66:41: warning: unused variable 'buf' [-Wunused-variable]
authz_cred_test.c:58:41: warning: unused variable 'arg' [-Wunused-variable]

globus-common

globus_options.c:117:13: warning: argument 1 null where non-null expected [-Wnonnull]
globus_args.c:94:5: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
globus_error_errno.c:265:41: warning: unused variable 'source_module' [-Wunused-variable]
globus_libc.c:369:9: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation]
error_test.c:122:49: warning: unused variable 'j' [-Wunused-variable]
error_test.c:121:49: warning: unused variable 'type' [-Wunused-variable]
fifo_test.c:51:45: warning: unused variable 'errorsOccurred' [-Wunused-variable]
fifo_test.c:46:45: warning: unused variable 'rc' [-Wunused-variable]
fifo_test.c:106:26: warning: 'middleItem' may be used uninitialized [-Wmaybe-uninitialized]
globus_args_scan_test.c:245:9: warning: unused variable 'i' [-Wunused-variable]
module_test.c:145:11: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
module_test.c:106:41: warning: unused variable 'successful_tests' [-Wunused-variable]
memory_test.c:115:17: warning: unused variable 'p' [-Wunused-variable]
timedwait_test.c:53:25: warning: unused variable 'successful_tests' [-Wunused-variable]
poll_test.c:191:41: warning: unused variable 'tests_passed' [-Wunused-variable]
poll_test.c:812:41: warning: unused variable 'tmp' [-Wunused-variable]

doxygen

library/globus_callback.h:595: warning: documented empty return type of globus_callback_signal_poll
library/globus_callback.h:549: warning: documented empty return type of globus_callback_space_poll
library/globus_thread.c:1552: warning: return value 'GLOBUS_TRUE' of globus_thread_equal has multiple documentation sections

globus-ftp-client

globus_ftp_client_attr.c:199:54: warning: 'c' may be used uninitialized [-Wmaybe-uninitialized]
globus_ftp_client_test_pause_plugin.c:266:19: warning: unused variable 'myname' [-Wunused-variable]
globus_ftp_client_test_pause_plugin.c:266:19: warning: 'myname' defined but not used [-Wunused-variable]
globus_ftp_client_test_pause_plugin.c:183:1: warning: 'globus_l_ftp_client_test_pause_plugin_command' defined but not used [-Wunused-function]
globus_ftp_client_test_restart_plugin.c:109:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
globus_ftp_client_test_restart_plugin.c:879:52: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
globus_ftp_client_test_restart_plugin.c:1060:1: warning: 'globus_l_ftp_client_test_restart_plugin_complete' defined but not used [-Wunused-function]
cksm-test.c:59:49: warning: unused variable 'buffer_length' [-Wunused-variable]
chmod-test.c:101:14: warning: 'mode' may be used uninitialized [-Wmaybe-uninitialized]
chgrp-test.c:101:14: warning: 'group' may be used uninitialized [-Wmaybe-uninitialized]
exist-test.c:59:49: warning: unused variable 'buffer_length' [-Wunused-variable]
lingering-get-test.c:70:5: warning: implicit declaration of function 'test_parse_args' [-Wimplicit-function-declaration]
lingering-get-test.c:58:49: warning: unused variable 'buffer_length' [-Wunused-variable]
modification-time-test.c:63:49: warning: unused variable 'tm' [-Wunused-variable]
modification-time-test.c:59:49: warning: unused variable 'buffer_length' [-Wunused-variable]
multiget-test.c:58:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
multiget-test.c:151:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
multiget-test.c:91:49: warning: unused variable 'result' [-Wunused-variable]
multiget-test.c:206:55: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
multiple-block-put-test.c:67:29: warning: format '%d' expects argument of type 'int', but argument 2 has type 'globus_size_t' {aka 'long unsigned int'} [-Wformat=]
size-test.c:59:49: warning: unused variable 'buffer_length' [-Wunused-variable]

doxygen

globus_ftp_client_perf_plugin.h:95: warning: argument 'time_stamp' of command @param is not found in the argument list of globus_ftp_client_perf_plugin_marker_cb_t(void *user_specific, globus_ftp_client_handle_t *handle, long time_stamp_int, char time_stamp_tength, int stripe_ndx, int num_stripes, globus_off_t nbytes)
globus_ftp_client_perf_plugin.h:95: warning: The following parameters of globus_ftp_client_perf_plugin_marker_cb_t(void *user_specific, globus_ftp_client_handle_t *handle, long time_stamp_int, char time_stamp_tength, int stripe_ndx, int num_stripes, globus_off_t nbytes) are not documented:
  parameter 'time_stamp_int'
  parameter 'time_stamp_tength'
globus_ftp_client_plugin.h:153: warning: The following parameter of globus_ftp_client_plugin_connect_t(globus_ftp_client_plugin_t *plugin, void *plugin_specific, globus_ftp_client_handle_t *handle, const char *url) is not documented:
  parameter 'url'
globus_ftp_client_plugin.h:1065: warning: The following parameter of globus_ftp_client_plugin_data_t(globus_ftp_client_plugin_t *plugin, void *plugin_specific, globus_ftp_client_handle_t *handle, globus_object_t *error, const globus_byte_t *buffer, globus_size_t length, globus_off_t offset, globus_bool_t eof) is not documented:
  parameter 'error'
globus_ftp_client_plugin.h:328: warning: argument 'link_url' of command @param is not found in the argument list of globus_ftp_client_plugin_symlink_t(globus_ftp_client_plugin_t *plugin, void *plugin_specific, globus_ftp_client_handle_t *handle, const char *url, const char *utime_time, const globus_ftp_client_operationattr_t *attr, globus_bool_t restart)
globus_ftp_client_plugin.h:328: warning: The following parameter of globus_ftp_client_plugin_symlink_t(globus_ftp_client_plugin_t *plugin, void *plugin_specific, globus_ftp_client_handle_t *handle, const char *url, const char *utime_time, const globus_ftp_client_operationattr_t *attr, globus_bool_t restart) is not documented:
  parameter 'utime_time'

other fixes

Spelling:
time_stamp_tenght -> time_stamp_tenth
time_stamp_tength -> time_stamp_tenth

globus-ftp-control

globus_ftp_control_server.c:1405:15: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'void *' [-Wformat=]
globus_ftp_control_server.c:1311:41: warning: unused variable 'src_name' [-Wunused-variable]
globus_ftp_control_client.c:4293:35: warning: 'c' may be used uninitialized [-Wmaybe-uninitialized]
globus_ftp_control_client.c:4391:14: warning: 'D' may be used uninitialized [-Wmaybe-uninitialized]
globus_ftp_control_client.c:2277:11: warning: 'read_queue_empty' may be used uninitialized [-Wmaybe-uninitialized]
globus_ftp_control_data.c:4513:49: warning: variable 'transfer_handle' set but not used [-Wunused-but-set-variable]
globus_ftp_control_data.c:5080:49: warning: variable 'transfer_handle' set but not used [-Wunused-but-set-variable]
globus_ftp_control_data.c:7657:50: warning: variable 'transfer_handle' set but not used [-Wunused-but-set-variable]
globus_ftp_control_data.c:7904:50: warning: variable 'destroy_it' set but not used [-Wunused-but-set-variable]
globus_ftp_control_data.c:7976:50: warning: variable 'transfer_handle' set but not used [-Wunused-but-set-variable]
/usr/include/globus/globus_libc.h:155:33: warning: 'eof_cb_ent' may be used uninitialized [-Wmaybe-uninitialized]
globus_ftp_control_data.c:4713:49: warning: 'result' may be used uninitialized [-Wmaybe-uninitialized]
abort_test.c:89:35: warning: pointer targets in passing argument 1 of 'pasv_to_host_port' differ in signedness [-Wpointer-sign]
test_common.c:231:46: warning: unused variable 'tmp' [-Wunused-variable]
connect_test.c:246:1: warning: label 'use_tls_fail' defined but not used [-Wunused-label]
connect_test.c:177:41: warning: unused variable 'auth_info' [-Wunused-variable]
connect_test.c:341:1: warning: label 'use_tls_fail' defined but not used [-Wunused-label]
connect_test.c:271:41: warning: unused variable 'auth_info' [-Wunused-variable]
connect_test.c:366:41: warning: unused variable 'auth_info' [-Wunused-variable]
connect_test.c:837:41: warning: unused variable 'tmp_ptr' [-Wunused-variable]
connect_test.c:1138:1: warning: label 'failed_other_attr_init' defined but not used [-Wunused-label]
outstanding_io_test.c:330:39: warning: pointer targets in passing argument 1 of 'pasv_to_host_port' differ in signedness [-Wpointer-sign]
eb_simple_data_test.c:404:39: warning: pointer targets in passing argument 1 of 'pasv_to_host_port' differ in signedness [-Wpointer-sign]
data_test.c:1150:42: warning: unused variable 'sys_cmd' [-Wunused-variable]
data_test.c:1265:47: warning: unused variable 'sys_cmd' [-Wunused-variable]
data_test.c:1420:47: warning: unused variable 'sys_cmd' [-Wunused-variable]
data_test.c:1563:48: warning: unused variable 'ctr' [-Wunused-variable]
data_test.c:1561:48: warning: unused variable 'done' [-Wunused-variable]
simple_data_test.c:317:39: warning: pointer targets in passing argument 1 of 'pasv_to_host_port' differ in signedness [-Wpointer-sign]
test_server.c:143:46: warning: unused variable 'tmp_ptr' [-Wunused-variable]
pipe_test.c:185:46: warning: unused variable 'queue_empty' [-Wunused-variable]

doxygen

globus_ftp_control.h:594: warning: The following parameter of globus_ftp_control_auth_callback_t(void *callback_arg, struct globus_ftp_control_handle_s *handle, globus_object_t *error, globus_ftp_control_auth_info_t *auth_result) is not documented:
  parameter 'error'
globus_ftp_control.h:1010: warning: argument 'result' of command @param is not found in the argument list of globus_ftp_control_server_callback_t(void *callback_arg, struct globus_ftp_control_server_s *server_handle, globus_object_t *error)
globus_ftp_control.h:1010: warning: The following parameter of globus_ftp_control_server_callback_t(void *callback_arg, struct globus_ftp_control_server_s *server_handle, globus_object_t *error) is not documented:
  parameter 'error'

globus-gass-copy

globus_gass_copy_glob.c:529:34: warning: comparison between pointer and zero character constant [-Wpointer-compare]
globus_gass_copy_glob.c:945:41: warning: variable 'filename' set but not used [-Wunused-but-set-variable]
globus_url_copy.c:3487:20: warning: comparison between pointer and zero character constant [-Wpointer-compare]
globus_url_copy.c:3762:28: warning: comparison between pointer and zero character constant [-Wpointer-compare]

doxygen

globus_gass_copy.h:644: warning: argument 'stat' of command @param is not found in the argument list of globus_gass_copy_glob_entry_cb_t(const char *url, const globus_gass_copy_glob_stat_t *info_stat, void *user_arg)
globus_gass_copy.h:644: warning: The following parameter of globus_gass_copy_glob_entry_cb_t(const char *url, const globus_gass_copy_glob_stat_t *info_stat, void *user_arg) is not documented:
  parameter 'info_stat'

globus-gass-server-ez

globus_gass_server_ez.c:352:12: warning: variable 'subjectname' set but not used [-Wunused-but-set-variable]
globus_gass_server_ez.c:455:18: warning: 'flags' may be used uninitialized [-Wmaybe-uninitialized]

globus-gass-transfer

globus_gass_transfer_http.c:2092:12: warning: 'rc' may be used uninitialized [-Wmaybe-uninitialized]

doxygen

globus_gass_transfer_proto.h:92: warning: argument 'bytes_length' of command @param is not found in the argument list of globus_gass_transfer_proto_send_t(globus_gass_transfer_request_proto_t *proto, globus_gass_transfer_request_t request, globus_byte_t *bytes, globus_size_t send_length, globus_bool_t last_data)
globus_gass_transfer_proto.h:92: warning: The following parameter of globus_gass_transfer_proto_send_t(globus_gass_transfer_request_proto_t *proto, globus_gass_transfer_request_t request, globus_byte_t *bytes, globus_size_t send_length, globus_bool_t last_data) is not documented:
  parameter 'send_length'

globus-gatekeeper

/usr/include/bits/stdio2.h:105:10: warning: 'rc' may be used uninitialized [-Wmaybe-uninitialized]
globus_gatekeeper_utils.c:405:17: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
globus_gatekeeper_utils.c:415:9: warning: implicit declaration of function 'initgroups'; did you mean 'getgroups'? [-Wimplicit-function-declaration]
globus_gatekeeper_utils.c:405:17: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
globus_gatekeeper_utils.c:415:9: warning: implicit declaration of function 'initgroups'; did you mean 'getgroups'? [-Wimplicit-function-declaration]
globus_gatekeeper.c:2222:29: warning: passing argument 2 to 'restrict'-qualified parameter aliases with argument 4 [-Wrestrict]
globus_gatekeeper.c:1496:9: warning: 'strncpy' specified bound 256 equals destination size [-Wstringop-truncation]

globus-gram-client

doxygen

globus_gram_client.c:337: warning: documented empty return type of globus_gram_client_debug

globus-gram-client-tools

globusrun.c:365:40: warning: variable 'ignore_ctrlc' set but not used [-Wunused-but-set-variable]

globus-gram-job-manager

globus_gram_job_manager_config.c:64:41: warning: unused variable 'tmp' [-Wunused-variable]
globus_gram_job_manager.c:1043:5: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation]
globus_gram_job_manager.c:1484:17: warning: 'ref' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_request.c:3963:1: warning: 'globus_l_gram_check_position' defined but not used [-Wunused-function]
globus_gram_job_manager_staging.c:370:41: warning: variable 'from_cached' set but not used [-Wunused-but-set-variable]
globus_gram_job_manager_staging.c:544:16: warning: 'list' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1416:30: warning: 'event_stamp' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1422:16: warning: 'terminated_normally' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1414:29: warning: 'subproc' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1414:29: warning: 'proc' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1414:29: warning: 'cluster' may be used uninitialized [-Wmaybe-uninitialized]
globus_gram_job_manager_seg.c:1400:9: warning: 'event_type_number' may be used uninitialized [-Wmaybe-uninitialized]
logging.c:59:41: warning: variable 'nowtm' set but not used [-Wunused-but-set-variable]
globus_gram_job_manager_state.c:158:41: warning: variable 'save_jobmanager_state' set but not used [-Wunused-but-set-variable]
globus_gram_job_manager_state.c:157:41: warning: variable 'save_status' set but not used [-Wunused-but-set-variable]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FILE_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_SCRATCH_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_CACHE_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_DONE' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_CLOSE_OUTPUT' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_TWO_PHASE_COMMITTED' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_FILE_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_SCRATCH_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_CACHE_CLEAN_UP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_FAILED_DONE' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_STOP' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_TWO_PHASE_QUERY1' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1649:5: warning: enumeration value 'GLOBUS_GRAM_JOB_MANAGER_STATE_TWO_PHASE_QUERY2' not handled in switch [-Wswitch]
globus_gram_job_manager_state.c:1380:9: warning: 'major_status' may be used uninitialized [-Wmaybe-uninitialized]
main.c:908:9: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation]
startup_socket.c:1450:25: warning: 'sent_fds' may be used uninitialized [-Wmaybe-uninitialized]
stdio-update-after-failure-test.c:300:1: warning: label 'still_streaming_check_failed' defined but not used [-Wunused-label]
stdio-update-after-failure-test.c:299:1: warning: label 'still_streaming_check_failed2' defined but not used [-Wunused-label]
stdio-update-after-failure-test.c:298:1: warning: label 'incorrect_size_error' defined but not used [-Wunused-label]
stdio-update-after-failure-test.c:297:1: warning: label 'commit_end_failed' defined but not used [-Wunused-label]
restart-to-new-url-test.c:437:1: warning: label 'done' defined but not used [-Wunused-label]

globus-gram-job-manager-fork

seg_fork_module.c:201:41: warning: variable 'save_errno' set but not used [-Wunused-but-set-variable]
/usr/include/globus/globus_debug.h:164:5: warning: 'save_errno' may be used uninitialized [-Wmaybe-uninitialized]

globus-gram-job-manager-sge

seg_sge_module.c:231:9: warning: implicit declaration of function 'setenv'; did you mean 'getenv'? [-Wimplicit-function-declaration]
seg_sge_module.c:395:32: warning: implicit declaration of function 'strdup' [-Wimplicit-function-declaration]
seg_sge_module.c:395:32: warning: incompatible implicit declaration of built-in function 'strdup' [-Wbuiltin-declaration-mismatch]
seg_sge_module.c:404:32: warning: incompatible implicit declaration of built-in function 'strdup' [-Wbuiltin-declaration-mismatch]
seg_sge_module.c:486:1: warning: label 'free_sge_root' defined but not used [-Wunused-label]

globus-gridftp-server

globus_gridftp_server_file.c:1126:53: warning: unused variable 'key' [-Wunused-variable]
globus_gridftp_server_file.c:1125:53: warning: unused variable 'h' [-Wunused-variable]
globus_gridftp_server_file.c:1189:27: warning: the comparison will always evaluate as 'true' for the address of 'd_name' will never be NULL [-Waddress]
globus_gridftp_server_file.c:1256:1: warning: label 'error_stat2' defined but not used [-Wunused-label]
globus_gridftp_server_file.c:1980:41: warning: unused variable 'freq' [-Wunused-variable]
globus_gridftp_server_file.c:1259:5: warning: 'dir' may be used uninitialized [-Wmaybe-uninitialized]
globus_gridftp_server_remote.c:391:41: warning: variable 'num_nodes' set but not used [-Wunused-but-set-variable]
globus_gridftp_server_remote.c:985:25: warning: 'list' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_log.c:88:41: warning: unused variable 'result' [-Wunused-variable]
globus_i_gfs_log.c:372:41: warning: unused variable 'list' [-Wunused-variable]
globus_i_gfs_embed.c:276:5: warning: 'handle' is used uninitialized [-Wuninitialized]
gfs_gfork_master.c:1571:5: warning: 'strncpy' specified bound 108 equals destination size [-Wstringop-truncation]
gfs_gfork_master.c:2054:20: warning: 'val' may be used uninitialized [-Wmaybe-uninitialized]
gfs_dynbe_client.c:213:5: warning: 'strncpy' specified bound 108 equals destination size [-Wstringop-truncation]
gfs_dynbe_client.c:273:5: warning: 'result' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_config.c:1884:41: warning: variable 'longflag' set but not used [-Wunused-but-set-variable]
globus_i_gfs_config.c:1883:41: warning: variable 'shortflag' set but not used [-Wunused-but-set-variable]
globus_i_gfs_config.c:2004:41: warning: variable 'longflag' set but not used [-Wunused-but-set-variable]
globus_i_gfs_config.c:2003:41: warning: variable 'shortflag' set but not used [-Wunused-but-set-variable]
globus_i_gfs_ipc.c:4936:16: warning: 'error_state' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4419:17: warning: 'data_arg' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4414:17: warning: 'data_info' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4404:17: warning: 'cmd_info' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4397:17: warning: 'trans_info' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4378:17: warning: 'stat_info' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4371:17: warning: 'user_buffer_type' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4371:17: warning: 'user_buffer_length' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_ipc.c:4371:17: warning: 'user_buffer' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:1128:5: warning: enumeration value 'GLOBUS_L_GFS_DATA_HANDLE_INUSE' not handled in switch [-Wswitch]
globus_i_gfs_data.c:1322:45: warning: unused variable 'tmp_path' [-Wunused-variable]
globus_i_gfs_data.c:2916:41: warning: variable 'session_info' set but not used [-Wunused-but-set-variable]
globus_i_gfs_data.c:5159:41: warning: unused variable 'driver' [-Wunused-variable]
globus_i_gfs_data.c:5157:41: warning: unused variable 'rc' [-Wunused-variable]
globus_i_gfs_data.c:5521:31: warning: pointer targets in assignment from 'gid_t *' {aka 'unsigned int *'} to 'int *' differ in signedness [-Wpointer-sign]
globus_i_gfs_data.c:7624:41: warning: variable 'old_state_dbg' set but not used [-Wunused-but-set-variable]
globus_i_gfs_data.c:9738:41: warning: variable 'last_state' set but not used [-Wunused-but-set-variable]
globus_i_gfs_data.c:11918:41: warning: unused variable 'result' [-Wunused-variable]
globus_i_gfs_data.c:12307:41: warning: unused variable 'code' [-Wunused-variable]
globus_i_gfs_data.c:13468:41: warning: unused variable 'result' [-Wunused-variable]
globus_i_gfs_data.c:2494:1: warning: 'globus_l_gfs_data_decode_passed_cred' defined but not used [-Wunused-function]
globus_i_gfs_data.c:778:17: warning: 'D' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:5787:22: warning: 'parsed_driver_string' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:5687:27: warning: 'prog' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:5086:54: warning: 'c' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:1736:48: warning: 'alias_ent' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:7849:13: warning: 'hybrid_op' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:8715:5: warning: 'op' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:8906:5: warning: 'op' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:9380:5: warning: 'result' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:14835:15: warning: 'next_line' may be used uninitialized [-Wmaybe-uninitialized]
globus_i_gfs_data.c:6875:5: warning: 'action' may be used uninitialized [-Wmaybe-uninitialized]
error_response_test.c:222:41: warning: unused variable 'result' [-Wunused-variable]

other fixes

Fix unbalanced mutex lock/unlock

globus-gridftp-server-control

globus_gridftp_server_control_accessors.c:50:45: warning: variable 'i_server' set but not used [-Wunused-but-set-variable]
globus_gridftp_server_control_commands.c:1092:45: warning: variable 'server_handle' set but not used [-Wunused-but-set-variable]
globus_gridftp_server_control_commands.c:1653:5: warning: 'msg' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gssapi_ftp.c:622:64: warning: 'c' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gssapi_ftp.c:554:18: warning: 'D' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gssapi_ftp.c:1450:27: warning: 'complete' may be used uninitialized [-Wmaybe-uninitialized]
/usr/include/globus/globus_libc.h:229:28: warning: 'msg' may be used uninitialized [-Wmaybe-uninitialized]
globus_gridftp_server_control.c:4687:23: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'void *' [-Wformat=]
globus_gridftp_server_control.c:1999:12: warning: 'res' may be used uninitialized [-Wmaybe-uninitialized]

globus-gsi-proxy-core

proxy-handle-compat-test.c:77:41: warning: unused variable 'handle' [-Wunused-variable]
proxy-handle-compat-test.c:68:20: warning: 'X509_EXTENSION_cmp' defined but not used [-Wunused-function]
proxy-handle-compat-test.c:67:20: warning: 'X509_REQ_cmp' defined but not used [-Wunused-function]
proxy-handle-test.c:88:41: warning: unused variable 'result' [-Wunused-variable]
proxy-handle-test.c:1066:41: warning: unused variable 'extensions' [-Wunused-variable]
proxy-handle-test.c:1064:41: warning: unused variable 'handle' [-Wunused-variable]
proxy-handle-test.c:1243:41: warning: unused variable 'handle' [-Wunused-variable]
proxy-handle-test.c:1492:1: warning: label 'no_handle' defined but not used [-Wunused-label]

globus-gsi-sysconfig

system-config-test.c:158:41: warning: unused variable 'ca_name_string' [-Wunused-variable]
system-config-test.c:157:41: warning: unused variable 'signing_policy_filename' [-Wunused-variable]

globus-gssapi-error

doxygen

globus_error_gssapi.c:176: warning: documented empty return type of globus_error_gssapi_set_major_status

globus-scheduler-event-generator

seg_api_test.c:67:9: warning: passing argument 1 of 'globus_scheduler_event_generator_set_event_handler' from incompatible pointer type [-Wincompatible-pointer-types]
globus_scheduler_event_generator_stdout.c:293:13: warning: pointer targets in passing argument 2 of 'globus_xio_register_read' differ in signedness [-Wpointer-sign]
globus_scheduler_event_generator_stdout.c:428:42: warning: pointer targets in passing argument 1 of 'globus_l_seg_register_write' differ in signedness [-Wpointer-sign]
globus_scheduler_event_generator_stdout.c:453:17: warning: pointer targets in passing argument 2 of 'globus_xio_register_read' differ in signedness [-Wpointer-sign]

globus-xio

globus_xio_http_header_info.c:182:37: warning: passing argument 1 of 'globus_libc_scan_off_t' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
globus_xio_http_transform.c:1494:12: warning: 'result' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_http_transform.c:1828:12: warning: 'result' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_tcp_driver.c:1429:51: warning: '__snprintf_chk' output may be truncated before the last format character [-Wformat-truncation=]
globus_xio_telnet.c:462:39: warning: 'dest_attr' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_telnet.c:462:39: warning: 'dest_attr' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_telnet.c:462:39: warning: 'dest_attr' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_udp_driver.c:1023:51: warning: '__snprintf_chk' output may be truncated before the last format character [-Wformat-truncation=]
version.h:18:18: warning: 'local_version' defined but not used [-Wunused-variable]
globus_xio_pass.c:400:41: warning: variable 'handle' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:256:41: warning: variable 'context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:527:41: warning: variable 'context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:526:41: warning: variable 'my_context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:522:41: warning: variable 'op_type' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:600:41: warning: variable 'context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:599:41: warning: variable 'my_context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:595:41: warning: variable 'op_type' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:873:41: warning: variable 'my_context' set but not used [-Wunused-but-set-variable]
globus_xio_driver.c:872:41: warning: variable 'context' set but not used [-Wunused-but-set-variable]
globus_xio_smtp.c:421:41: warning: variable 'info' set but not used [-Wunused-but-set-variable]
globus_xio_smtp.c:392:12: warning: 'res' is used uninitialized [-Wuninitialized]
globus_xio_smtp.c:431:12: warning: 'res' is used uninitialized [-Wuninitialized]
globus_xio_smtp.c:344:12: warning: 'res' may be used uninitialized [-Wmaybe-uninitialized]
close_barrier2_test.c:145:45: warning: unused variable 'end_time' [-Wunused-variable]
cancel_test.c:189:45: warning: unused variable 'opt_offset' [-Wunused-variable]
framework_test.c:55:49: warning: variable 'info' set but not used [-Wunused-but-set-variable]
http_get_test.c:531:41: warning: variable 'to_read' set but not used [-Wunused-but-set-variable]
http_post_test.c:582:41: warning: variable 'to_read' set but not used [-Wunused-but-set-variable]
http_pingpong_test.c:288:12: warning: 'rc' may be used uninitialized [-Wmaybe-uninitialized]
http_put_test.c:503:41: warning: variable 'to_read' set but not used [-Wunused-but-set-variable]

doxygen

globus_xio.h:504: warning: argument 'arg' of command @param is not found in the argument list of globus_xio_timeout_callback_t(globus_xio_handle_t handle, globus_xio_operation_type_t type, void *user_arg)
globus_xio.h:504: warning: The following parameter of globus_xio_timeout_callback_t(globus_xio_handle_t handle, globus_xio_operation_type_t type, void *user_arg) is not documented:
  parameter 'user_arg'
globus_xio_driver.h:386: warning: argument 'driver_attr' of command @param is not found in the argument list of globus_xio_driver_attr_cntl_t(void *attr, int cmd, va_list ap)
globus_xio_driver.h:386: warning: The following parameter of globus_xio_driver_attr_cntl_t(void *attr, int cmd, va_list ap) is not documented:
  parameter 'attr'
globus_xio_driver.h:794: warning: argument 'driver_specific_handle' of command @param is not found in the argument list of globus_xio_driver_close_t(void *driver_handle, void *driver_attr, globus_xio_operation_t op)
globus_xio_driver.h:794: warning: The following parameter of globus_xio_driver_close_t(void *driver_handle, void *driver_attr, globus_xio_operation_t op) is not documented:
  parameter 'driver_handle'
globus_xio_driver.h:861: warning: argument 'driver_handle' of command @param is not found in the argument list of globus_xio_driver_read_t(void *driver_specific_handle, const globus_xio_iovec_t *iovec, int iovec_count, globus_xio_operation_t op)
globus_xio_driver.h:861: warning: The following parameter of globus_xio_driver_read_t(void *driver_specific_handle, const globus_xio_iovec_t *iovec, int iovec_count, globus_xio_operation_t op) is not documented:
  parameter 'driver_specific_handle'
globus_xio_driver.h:473: warning: argument 'server' of command @param is not found in the argument list of globus_xio_driver_server_destroy_t(void *driver_server)
globus_xio_driver.h:1011: warning: argument 'driver_handle' of command @param is not found in the argument list of globus_xio_driver_write_t(void *driver_specific_handle, const globus_xio_iovec_t *iovec, int iovec_count, globus_xio_operation_t op)
globus_xio_driver.h:1011: warning: The following parameter of globus_xio_driver_write_t(void *driver_specific_handle, const globus_xio_iovec_t *iovec, int iovec_count, globus_xio_operation_t op) is not documented:
  parameter 'driver_specific_handle'

globus-xio-gridftp-driver

globus_xio_gridftp_driver.c:820:16: warning: 'error_info' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gridftp_driver.c:1131:9: warning: 'requestor_length' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gridftp_driver.c:1125:32: warning: 'requestor_offset' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gridftp_driver.c:1125:32: warning: 'requestor_op' may be used uninitialized [-Wmaybe-uninitialized]
globus_gridftp_driver_test.c:235:14: warning: 'filename' may be used uninitialized [-Wmaybe-uninitialized]

globus-xio-gridftp-multicast

globus_xio_gridftp_multicast_driver.c:300:21: warning: comparison between pointer and zero character constant [-Wpointer-compare]
globus_xio_gridftp_multicast_driver.c:266:41: warning: variable 'len' set but not used [-Wunused-but-set-variable]
globus_xio_gridftp_multicast_driver.c:246:19: warning: 'ftp_handle' may be used uninitialized [-Wmaybe-uninitialized]
globus_xio_gridftp_multicast_driver.c:1320:15: warning: 'wait_for' may be used uninitialized [-Wmaybe-uninitialized]

myproxy

gssapi.c:298:40: warning: passing argument 3 of '_plug_buf_alloc' from incompatible pointer type [-Wincompatible-pointer-types]
gssapi.c:322:44: warning: passing argument 3 of '_plug_buf_alloc' from incompatible pointer type [-Wincompatible-pointer-types]
gssapi.c:340:40: warning: passing argument 3 of '_plug_buf_alloc' from incompatible pointer type [-Wincompatible-pointer-types]
gssapi.c:367:44: warning: passing argument 3 of '_plug_buf_alloc' from incompatible pointer type [-Wincompatible-pointer-types]
gssapi.c:383:40: warning: passing argument 3 of '_plug_buf_alloc' from incompatible pointer type [-Wincompatible-pointer-types]
gssapi.c:89:19: warning: 'plugin_id' defined but not used [-Wunused-const-variable=]
gsi_socket.c:636:33: warning: unused variable 'target_name_type' [-Wunused-variable]
gsi_socket.c:635:33: warning: unused variable 'target_name' [-Wunused-variable]
myproxy.c:854:16: warning: unused variable 'rc' [-Wunused-variable]
myproxy.c:850:21: warning: unused variable 'buf' [-Wunused-variable]
myproxy.c:2847:23: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
myproxy_server_config.c:1347:22: warning: the comparison will always evaluate as 'false' for the address of 'name' will never be NULL [-Waddress]
vomsclient.c:307:5: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
vomsclient.c:274:5: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation]
vomsclient.c:226:5: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation]
ssl_utils.c:15:37: warning: left-hand operand of comma expression has no effect [-Wunused-value]
myproxy_alcf.c:98:22: warning: variable 'creds' set but not used [-Wunused-but-set-variable]
myproxy_server.c:1948:20: warning: the comparison will always evaluate as 'true' for the address of 'passphrase' will never be NULL [-Waddress]
myproxy_server.c:2258:71: warning: the comparison will always evaluate as 'true' for the address of 'passphrase' will never be NULL [-Waddress]

[fscheiner]

Wow Mattias (@ellert), that must have been a long and demanding task. Much obliged that you went after these compiler warnings. This PR looks like a huge improvement in quality for the GCT.

---

Sorry, but the review became a long haul for me. And it looks like I can't comment on parts of the changes separate from the review when I already started a review, so my comments are not visible until after I make my review comment. So again, sorry for taking so long.

---

For the change in the mutex (un)locking in gridftp/server/src/globus_gridftp_server.c after a lot of tries I managed to get a situation which looked like a deadlock. I performed test runs in a single VM with 6 virtual CPUs attached that generates more than 400 threads for a single transfer. One test run took too long compared to other test runs with practically no load on the CPUs, so I cancelled it and found myself in the following situation:

## Standard number of processes:
## 6 DTPs
## 1 PI
## 1 line for `grep` command
[johndoe@gridftp-5 ~]$ ps auxf | grep globus-gridftp-server | wc -l
8

## After cancelling the test
[johndoe@gridftp-5 ~]$ ps auxf | grep globus-gridftp-server | wc -l
14

## After stopping the gridftpd...
[johndoe@gridftp-5 ~]$ sudo gridftpd/etc/init.d/gridftpd stop
[sudo] password for johndoe: 
Stopping gridftpd:                                         [  OK  ]

## ...there are still 5 DTPs and 1 PI running
[johndoe@gridftp-5 ~]$ ps auxf | grep globus-gridftp-server | wc -l
7

But before I was able to attach gdb to one of these processes (I wasn't prepared for that and first had to install gdb :-() the "still running but not consuming CPU time" globus-gridftp-server (ggs) processes were gone.

But this was for a ggs that had this PR here applied unfortunately. :-(

I didn't yet manage to create a similar situation with the ggs at da14279.

I would like to do some testing between two VMs located on two different hosts before approving the mutex (un)locking change. But this will take some time.

[fscheiner]

Once again, great work Mattias (@ellert). I'm glad we have you in the GridCF. :-)

Give me until evening to do my testing and then let's merge this. I'll add an approving review comment until then.

[fscheiner]

Ok, didn't notice anything fishy during my testing (with up to 800 processes/threads per transfer). No difference in behaviour this time between da14279 and f170e00.

[fscheiner]

Let's merge this!

[maarten-litmaath]

Thanks & congrats, guys!