Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendtoaddress does not set the transaction message #1346

Closed
tomasbrod opened this issue Oct 26, 2018 · 15 comments
Closed

Sendtoaddress does not set the transaction message #1346

tomasbrod opened this issue Oct 26, 2018 · 15 comments

Comments

@tomasbrod
Copy link
Member

No description provided.

@iFoggz
Copy link
Member

iFoggz commented Nov 8, 2018

I fail to see what you mean? are you referring to the comment and comment-to these were never intended to be in transaction. they are just for local reference for yourself. bitcoin does the same as well. thou I don't see why we cannot add another field if you'd like a tx message sent with transaction

@tomasbrod
Copy link
Member Author

I know that one of them is for local reference only, but wasn't the other intended to be in transaction?

@barton2526
Copy link
Member

@denravonska Can we please move this to a milestone? The issue keeps coming up and needs to be fixed.

@jamescowens jamescowens added this to the Denise milestone Feb 5, 2019
@jamescowens
Copy link
Member

I am assigning this to Denise.

@satonakamo
Copy link

i would like to offer a bounty of 2500 GRC payable to whomever submits the first working solution to the repository.

@barton2526
Copy link
Member

@denravonska please add bounty tag

@denravonska
Copy link
Member

comment and comment-to are both just stored as text with the transaction. The intent is that comment be used to store what the transaction is for, and comment-to be used to store the name of the person or organization to which you're sending the transaction.

@satonakamo Do you want to include a message as well?

@satonakamo
Copy link

@denravonska actually that's is the only thing I want, the message in the hashBoinc field of the transaction. Thanks for looking into it.

@jamescowens
Copy link
Member

jamescowens commented Feb 9, 2019 via email

@satonakamo
Copy link

satonakamo commented Feb 9, 2019

how do you mean? as far as I can see the hashBoinc field is where messages go, or am I mistaken

{"txid":"71fc138fc315c11da5a8a2171d468ec8bb78a587213499b6dde440dea6c39553","version":1,"time":1549318857,"locktime":0,"hashboinc":"<MESSAGE>49 0 #7a02ec</MESSAGE>","vin":

ok maybe I should clarify further: I am interested in being able to set the message field from the RPC command sendtoaddress. I am not proposing that the comment and comment-to be entered into the hashBoinc field.

@denravonska
Copy link
Member

@jamescowens That is how we send messages. It seems like the only way to send messages now is by using the Qt UI.

@jamescowens
Copy link
Member

jamescowens commented Feb 9, 2019 via email

@denravonska
Copy link
Member

@satonakamo Would an additional message argument be sufficient for you?

@satonakamo
Copy link

@denravonska yes, thank you very much.
can you claim the bounty from bountysource?

@denravonska
Copy link
Member

@satonakamo I can claim it when #1400 is accepted and this issue is closed.

@denravonska denravonska modified the milestones: Denise, Camilla Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants