Rpc changes (Large) #1024

iFoggz · 2018-03-15T01:08:09Z

I know it is a lot of commits but it was alot of changes and some refactoring as well. merge conflicts now resolved. will still touch this during testing and modify and verify locks.

all list and execute commands are now normal rpc calls.
fDebug4 now logs the rpc call times from inside the rpc. (note calling the daemon to connect to port and call a command can also add time ofcourse.

plan to remove some deprecated commands still but leaving this open for now in case some issues need to be addressed

…c calls beyond runtime return for rpc help or missing parameters; modified some locks to meet how bitcoin does it for the same task; reduced the scope sizes in the end;

…ute burn to execute burn2. removed resendwallettx as it functions identically to resendtx rpc calls

iFoggz · 2018-03-15T01:08:35Z

some WIP still

iFoggz · 2018-03-15T01:09:07Z

@barton2526 u can start spell checking.

iFoggz · 2018-03-15T02:15:47Z

i will address compile issues as well

barton2526 · 2018-03-15T02:37:21Z

src/bitcoinrpc.cpp

-
+// We no longer use the unlocked feature here.
+// Bitcoin has removed this option and placed the locks inside the rpc calls to reduce the scope
+// Also removes the un needed locking when the end result is a rpc run time error reply over params!


should be "unneeded"

barton2526 · 2018-03-15T04:28:36Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Spelling error. Should be "Requests". Also should be "quorum"

barton2526 · 2018-03-15T04:29:39Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Suggest rephrasing to "Displays a report on various versions that have recently staked on the network\n"

barton2526 · 2018-03-15T04:30:48Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Should be "voters" plural

barton2526 · 2018-03-15T04:31:57Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Point to Community Tasks Repo

barton2526 · 2018-03-15T04:33:04Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Needs better description

barton2526 · 2018-03-15T04:34:02Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Unix time does not have a timezone. Should be rephrased as "Displays current unix time as well as date and time in UTC\n"

barton2526 · 2018-03-15T04:34:45Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Spelling error. Should say "Phrase"

barton2526 · 2018-03-15T04:39:58Z

src/rpcblockchain.cpp

-            std::string sType = params[2].get_str();
-            entry.push_back(Pair("Type",sType));
-            std::string sPass = "";
-            sPass = (sType=="project" || sType=="projectmapping") ? GetArgu


Remove "so"

"execute function has been deprecated; run the command as previously done but without execute"

barton2526 · 2018-03-15T04:40:30Z

src/rpcblockchain.cpp

-    }
-    return results;
-
+    throw JSONRPCError(RPC_DEPRECATED, "list is deprecated; Please run the command the same as previously without list");


Suggest same format as execute deprecate

barton2526 · 2018-03-15T04:43:43Z

src/rpcnet.cpp

@@ -23,9 +23,11 @@ Value getconnectioncount(const Array& params, bool fHelp)
    if (fHelp || params.size() != 0)
        throw runtime_error(
            "getconnectioncount\n"
-            "Returns the number of connections to other nodes.");
+            "\n"
+            "Returns the number of connections to other node\n.");


Needs plural. Should be "Returns the number of connections to other nodes\n"

barton2526 · 2018-03-15T04:45:18Z

src/rpcnet.cpp

-            "Returns data about each connected network node.");
+                "getpeerinfo\n"
+                "\n"
+                "Returns data about each connected network node.");


Needs newline

barton2526 · 2018-03-15T04:49:24Z

src/rpcrawtransaction.cpp

+                "     ]\n"
+                "2. \"outputs\"             (string, required) a json object with outputs\n"
+                "    {\n"
+                "      \"address\": x.xxx   (numeric, required) The key is the bitcoin address, the value is the CURRENCY_UNIT amount\n"


Should say Gridcoin address, not bitcoin

barton2526 · 2018-03-15T04:55:14Z

src/rpcwallet.cpp

+                "2. minconf          (numeric, optional, default=1) Only include transactions confirmed at least this many times.\n"
+                "3. includeWatchonly (bool, optional, default=false) Also include balance in watchonly addresses (see 'importaddress')\n"
+                "\nResult:\n"
+                "amount              (numeric) The total amount in btc received for this account.\n"


Change btc to grc

barton2526 · 2018-03-15T04:57:20Z

src/rpcwallet.cpp

+                "    \"involvesWatchonly\" : \"true\",    (bool) Only returned if imported addresses were involved in transaction\n"
+                "    \"address\" : \"receivingaddress\",  (string) The receiving address\n"
+                "    \"account\" : \"accountname\",       (string) The account of the receiving address. The default account is \"\".\n"
+                "    \"amount\" : x.xxx,                  (numeric) The total amount in btc received by the address\n"


change btc to grc

barton2526 · 2018-03-15T04:57:39Z

src/rpcwallet.cpp

+                "    \"address\" : \"receivingaddress\",  (string) The receiving address\n"
+                "    \"account\" : \"accountname\",       (string) The account of the receiving address. The default account is \"\".\n"
+                "    \"amount\" : x.xxx,                  (numeric) The total amount in btc received by the address\n"
+                "\nExamples:\n"


No examples are given

barton2526 · 2018-03-15T04:58:43Z

src/rpcwallet.cpp

+                  "  {\n"
+                  "    \"account\":\"accountname\",       (string) The account name associated with the transaction. \n"
+                  "                                                It will be \"\" for the default account.\n"
+                  "    \"address\":\"bitcoinaddress\",    (string) The bitcoin address of the transaction. Not present for \n"


Change "bitcoin" to "gridcoin"

barton2526 · 2018-03-15T04:59:07Z

src/rpcwallet.cpp

+                  "                                                transaction between accounts, and not associated with an address,\n"
+                  "                                                transaction id or block. 'send' and 'receive' transactions are \n"
+                  "                                                associated with an address, transaction id and block details\n"
+                  "    \"amount\": x.xxx,          (numeric) The amount in btc. This is negative for the 'send' category, and for the\n"


Change btc to grc

barton2526 · 2018-03-15T04:59:20Z

src/rpcwallet.cpp

+                  "    \"amount\": x.xxx,          (numeric) The amount in btc. This is negative for the 'send' category, and for the\n"
+                  "                                         'move' category for moves outbound. It is positive for the 'receive' category,\n"
+                  "                                         and for the 'move' category for inbound funds.\n"
+                  "    \"fee\": x.xxx,             (numeric) The amount of the fee in btc. This is negative and only available for the \n"


change btc to grc

barton2526 · 2018-03-15T05:03:25Z

src/rpcwallet.cpp

-            "Repair wallet if checkwallet reports any problem.\n");
+                "repairwallet\n"
+                "\n"
+                "Repair wallet if checkwallet reports any problem.\n");


Suggest making problem plural. "Repair wallet if checkwallet reports any problems.\n"

barton2526 · 2018-03-15T05:05:25Z

@Foggyx420 Initial spellcheck complete. Please let me know if anything I commented is unclear. Apologies to all for the suggestions spam!

ghost · 2018-03-15T10:59:22Z

src/bitcoinrpc.cpp

+            "wallet --------> Returns help for blockchain related commands\n"
+            "mining --------> Returns help for neural network/cpid/beacon related commands\n"
+            "developer -----> Returns help for developer commands\n"
+            "network -------> Returns help for network related commands\n");


This returns with (code -1) and in red in the Wallet rpcconsole

coudl be i'll check and i wouldnt be surprised as the merge conflicts from a horror movies i had to work out lol.

ya categories work i just got to fix the pass through for help from the commands. which was fine before merging recent changes. no problems. will do it later today

i can confirm that help works help wallet help mining help developer and help network works but help commandshere does not however that will be a easy fix i remember i didnt save the fix for that for some reason.

tomasbrod · 2018-03-15T11:13:37Z

Instead of posting all these comments, @barton2526, you could have done the correcting change and submitted a PR to a PR.

TheCharlatan · 2018-03-16T02:35:42Z

Nice stuff! Can you convert the printf to the new tinyformat LogPrintf?

denravonska · 2018-03-16T02:50:57Z

Merging this after the printf changes and compile issues so we can flesh it out in staging.

iFoggz · 2018-03-17T21:12:53Z

sorry guy i been busy and sick. will fix the spelling issues etc and post a new pr since this has been accepted. do test away and barton will cprdinate this

barton2526 · 2018-03-19T19:25:50Z

We have largely finished stress testing this in testnet and are now moving onto testing the individual RPC commands for correct output and errors.

tomasbrod · 2018-04-20T16:03:57Z

Please close #960

@skcin

Fixed - Fixes for displaying on high DPI displays, #517 (@skcin). - Re-enable unit tests, add unit test to Travis, #769, #808 (@TheCharlatan). - Fix empty string in sendalert2 (@tomasbrod). Added - Neural Report RPC command, #1063 (@tomasbrod). - GUI wallet redign with new icons and purple native style (@skcin). Changed - Switch to autotools and Depends from Bitcoin, #487 (@TheCharlatan). - Clean and update docs for new build system, remove outdated, #828 (@TheCharlatan). - Change estimated time to stake calculations to be more accurate, #1084 (@jamescowens). - Move logging to tinyformat, #1009 (@TheCharlatan). - Improve appcache performance, #734 (@denravonska). - Improve block index memory access performance, #679 (@denravonska). - NN fixes: clean logging, explain mag single response, move contract to ndata_nresp (@denravonska) - Updated translations: - Turkish, #771 (@confuest). - Chinese, #1012 (@linnaea). - RPC refactor: Cleaner locks, better error handling, move execute calls to straght rpc calls, #1024 (@Foggyx420). - Change locking primitives from Boost to STL, #1029 (@Foggyx420). Removed - gridcoindiagnostic RPC call (@denravonska). - Galaza, #945 (@barton2526). - Assertion in SignSignature, #998 (@TheCharlatan). - Upgrade menu, #1094 (@jamescowens). - Acid test functions, #871 (@tomasbrod). - Qt4 support, #801 (@denravonska).

iFoggz added 26 commits March 14, 2018 14:28

remove extra space from error message

da46408

bitcoinrpc changes and testing complete

bcdbd10

initial changes for last of testing

0e058a3

Remove unlocked feature no longer used by bitcoin; Move locks into rp…

4fa945d

…c calls beyond runtime return for rpc help or missing parameters; modified some locks to meet how bitcoin does it for the same task; reduced the scope sizes in the end;

move some of the execute rpc calls into straight rpc calls. move exec…

ac5e077

…ute burn to execute burn2. removed resendwallettx as it functions identically to resendtx rpc calls

fix rpc bug and support for subcategories

c5f4fa9

latest changes

072dbc2

Add debug4 for rpc response times

2069cba

..

2b95193

complete mining category

afa5e08

more of developer category complete

c0d8dfc

Complete developers category

da8fb12

update changes

365edbe

more done

7cebebd

Complete with some refactoring; TODO spacing

afacace

Fix compiler issues

a974c90

Add getwalletinfo, getblockchaininfo, getnetworkinfo

6b783e1

refactor fdebug4 a bit

554b53d

add debug4 to rpc

02e00e3

Start clean up of code

da6f8e2

Add RPC_DEPRECATED json error

03eb989

cleanup

c147ceb

clean up + prep for help refactoring

3260bed

Moved/changed/added locks

b35ea54

Moved/changed locks

7af41a3

Adjustments

d5e1bd4

barton2526 reviewed Mar 15, 2018

View reviewed changes

ghost reviewed Mar 15, 2018

View reviewed changes

fix help <command>; fix win32 compiliation errors

7aa7ec8

denravonska merged commit 0c7b622 into gridcoin-community:development Mar 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rpc changes (Large) #1024

Rpc changes (Large) #1024

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018 •

edited

Loading

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018 •

edited

Loading

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 Mar 15, 2018

barton2526 commented Mar 15, 2018

ghost Mar 15, 2018

iFoggz Mar 15, 2018

iFoggz Mar 15, 2018

iFoggz Mar 15, 2018

tomasbrod commented Mar 15, 2018

TheCharlatan commented Mar 16, 2018

denravonska commented Mar 16, 2018 •

edited

Loading

iFoggz commented Mar 17, 2018

barton2526 commented Mar 19, 2018

tomasbrod commented Apr 20, 2018

Rpc changes (Large) #1024

Rpc changes (Large) #1024

Conversation

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

iFoggz commented Mar 15, 2018

Choose a reason for hiding this comment

barton2526 Mar 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barton2526 Mar 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barton2526 commented Mar 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomasbrod commented Mar 15, 2018

TheCharlatan commented Mar 16, 2018

denravonska commented Mar 16, 2018 • edited Loading

iFoggz commented Mar 17, 2018

barton2526 commented Mar 19, 2018

tomasbrod commented Apr 20, 2018

barton2526 Mar 15, 2018 •

edited

Loading

barton2526 Mar 15, 2018 •

edited

Loading

denravonska commented Mar 16, 2018 •

edited

Loading