Remove (lower) Mint Limiter #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for bottom mint limit conditioned to version less than 10.
|
Was there a reason for the lower limit in the first place or was it purely aestethic? |
|
@barton2526 made a comment on Slack that it was both aesthetic and technical... It was to prevent dust staking. I will point out that with V8+, which does staking on UTXO value only, this problem takes care of itself. A very small UTXO will also have an exceedingly small probability of staking, hence, dust stakes will be extremely rare to nonexistent -> no need for the mint limiter anymore. The code has to hang around for block validation < V10, and that is the only reason @tomasbrod's change didn't delete it entirely. We don't want to do grandfathering here. |
|
Why don’t we just change the mint limiter to have a flat test for that tiny value or above?
…Sent from my iPhone
On Jul 26, 2018, at 2:39 PM, Marco Nilsson ***@***.***> wrote:
There are at least two pieces which expect the PoR payment to end at 124 so we need to see if it's an issue if you stake a tiny amount which is less than that. How that number gets there is beyond me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
denravonska
added a commit
that referenced
this pull request
Oct 19, 2018
Added: - Linux nodes can now stake superblocks using forwarded contracts #1060 (@tomasbrod). Changed: - Replace interest with constant block reward #1160 (@tomasbrod). Fork is set to trigger at block 1420000. - Raise coinstake output count limit to 8 #1261 (@tomasbrod). - Port of Bitcoin hash implementation #1208 (@jamescowens). - Minor canges for the build documentation #1091 (@Lenni). - Allow sendmany to be used without an account specified #1158 (@Foggyx420). Fixed: - Fix `cpids` and `validcpids` not returning the correct data #1233 (@Foggyx420). - Fix `listsinceblock` not showing mined blocks to change addresses #501 (@Foggyx420). - Fix crash when raining using a locked wallet #1236 (@Foggyx420). - Fix invalid stake reward/fee calculation (@jamescowens). - Fix divide by zero bug in `getblockstats` RPC #1292 (@Foggyx420). - Bypass historical bad blocks on testnet #1252 (@Quezacoatl1). - Fix MacOS memorybarrier warnings #1193 (@ghost). Removed: - Remove neuralhash from the getpeerinfo and node stats #1123 (@Foggyx420). - Remove obsolete NN code #1121 (@Foggyx420). - Remove (lower) Mint Limiter #1212 (@tomasbrod).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.