additional condition to beacon timer #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…advertise beacon thinking it needs to be advertised. We shall prevent this instance
|
Locking issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rare occasion GlobalCPUMiningCPID.cpid was not populated and the timer checks for a BeaconPublicKey. and if you send "" when it is not populated it will think you need your beacon advertised causing it to say unable to advertise beacon yet in log say it is already in chain.
Here we add another condition to the BeaconPublicKey is empty. We and if GlobalCPUMiningCPID.cpid is not empty go ahead with advertising.