Revert lock order from #708. #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This order is still used in blackcoin. Any order which violates this is a new regression introduced in Gridcoin and should be changed. The cs_main scope has also been reduced which fixes the RPC and UI slowdowns when syncing.
|
This plus my future rpc changes will be improvements since scopes of locks in rpc will be reduced as well and should improve for exchanges using rpc calls. |
iFoggz
approved these changes
Feb 22, 2018
denravonska
added a commit
that referenced
this pull request
Mar 1, 2018
Fixed: - Move context sensitive DPoR block checks to ConnectBlock, #912 (@tomasbrod). - Check incoming blocks for malformed DPoR signature, #912. - Corect tally height on init, #917 (@denravonska). - Prevent staking of a block with a failed signature, #948 (@Foggyx420). - Fix UI and RPC slowdown regression, #961 (@denravonska). - Fix Debian lint errors, #886, #885, #884, #883 (@caraka). - Fix fork issue due to research age calculation inconsistencies, #939 (@denravonska). - Fix crashes when tallying, #934 (@denravonska). - Revert reorganize of the chain trust becomes less than what it was, #957 (@tomasbrod). - Fix sync issues with incorrectly accepted v8 beacons, #979 (@tomasbrod). Changed: - Double check PoS kernel, #958 (@tomasbrod). - Don't tally until V9 to speed up syncing, #943 (@denravonska). - Double check proof of stake kernel, #958 (@tomasbrod).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the lock order in #708 and reduces the granularity of the locks (taken from Blackcoin). As a result, RPC, and probably the UI, will not freeze up during syncing. I tested this on the daemon by syncing from 0 without any issues.
To test: