Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change filter for beacon report to beacon; datatype instead of beacon. note beaconalt #986

Merged
merged 2 commits into from
Mar 3, 2018
Merged

change filter for beacon report to beacon; datatype instead of beacon. note beaconalt #986

merged 2 commits into from
Mar 3, 2018

Conversation

iFoggz
Copy link
Member

@iFoggz iFoggz commented Mar 2, 2018

Have beacon report specifically filter with datatype beacon; since beacon; alone as currently it now displays the beaconalt; cache entries as well. in turn beacon report DecodeBase64 the contract so when it does these beaconalt; entries it can put out binary data results. and noting with decodebase64 could possibly be able to seg fault in limited situations this should be in place to prevent that possibility.

@iFoggz
Have beacon report specifically filter with datatype beacon; since be…
e67dfb6 
…acon alone now displays the beaconalt; as well. in turn beacon report decodesbase64 the contract so when it does these beaconalt; entries it can put out binary data results. and noting with decodebase64 be able to seg fault in limited situations this should be in place to prevent that possibility
@iFoggz
Copy link
Member Author

iFoggz commented Mar 2, 2018

tested and works

@iFoggz
Copy link
Member Author

iFoggz commented Mar 2, 2018

  • Updated PushGridcoinDiagnostics to use beacon; for time being even thou we are not currently using this and we may in future and minds well have it set for now.
  • Modified GetListOfWithConsensus to ignore beaconalt; which broke the neural network and beacon count.
  • Converted tabs to 4 spaces while i was there
    Neural network functions once again

@denravonska denravonska changed the base branch from master to hotfix March 3, 2018 08:13
@denravonska denravonska merged commit e4038ba into gridcoin-community:hotfix Mar 3, 2018
denravonska added a commit that referenced this pull request Mar 3, 2018
@denravonska
3.7.9.0-Leisure
3357395 
Fixed:
 - Fix issues with NN participation on Windows, #986 (@Foggyx420).
 - Fix stray data in beaconreport RPC, #986 (@Foggyx420).
 - Fix spelling error, #989 (@caraka).
@tomasbrod
Copy link
Member

Thanks. I haven't tried that when working on my pr #979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iFoggz @tomasbrod @denravonska