IGNITE-21911 Change API usage of Placement driver in Index module from TablePartitionId to ZonePartitionId #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m TablePartitionId to ZonePartitionId
alievmirza
force-pushed
the
ignite-21911-in-feature-branch
branch
from
e10f113
to
4d10b39
Compare
alievmirza
changed the title
JAkutenshi
approved these changes
Apr 22, 2024
| .enlistmentConsistencyToken(meta.getStartTime().longValue()) | ||
| .groupId(partId) | ||
| // TODO: discuss this timeout | ||
| .timeout(10) |
sanpwc
reviewed
Apr 23, 2024
...test/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptorTest.java
Show resolved
Hide resolved
...st/java/org/apache/ignite/internal/catalog/descriptors/CatalogSortedIndexDescriptorTest.java
Show resolved
Hide resolved
...-handler/src/test/java/org/apache/ignite/client/handler/ClientPrimaryReplicaTrackerTest.java
Outdated
Show resolved
Hide resolved
modules/client/src/test/java/org/apache/ignite/client/PartitionAwarenessTest.java
Outdated
Show resolved
Hide resolved
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java
Outdated
Show resolved
Hide resolved
modules/index/src/test/java/org/apache/ignite/internal/index/IndexBuildControllerTest.java
Outdated
Show resolved
Hide resolved
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java
Outdated
Show resolved
Hide resolved
...replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaAwareLeaseTracker.java
Show resolved
Hide resolved
...replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaAwareLeaseTracker.java
Show resolved
Hide resolved
...replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaAwareLeaseTracker.java
Show resolved
Hide resolved
sanpwc
reviewed
Apr 23, 2024
modules/table/src/testFixtures/java/org/apache/ignite/internal/table/TableTestUtils.java
Outdated
Show resolved
Hide resolved
vldpyatkov
reviewed
Apr 23, 2024
| @@ -339,11 +340,13 @@ private CompletableFuture<Boolean> primaryReplicaEventListener( | |||
| Consumer<TablePartitionId> action | |||
| ) { | |||
| return inBusyLock(busyLock, () -> { | |||
| if (!(eventParameters.groupId() instanceof TablePartitionId)) { | |||
| if (!(eventParameters.groupId() instanceof ZonePartitionId)) { | |||
There was a problem hiding this comment.
I prefer to leave it as it was in the main
| @@ -292,11 +293,13 @@ void stop() { | |||
|
|
|||
| private void onPrimaryReplicaChanged(PrimaryReplicaEventParameters primaryReplicaEvent) { | |||
| inBusyLock(busyLock, () -> { | |||
| if (!(primaryReplicaEvent.groupId() instanceof TablePartitionId)) { | |||
| if (!(primaryReplicaEvent.groupId() instanceof ZonePartitionId)) { | |||
There was a problem hiding this comment.
This condition can be replaced with assert.
There was a problem hiding this comment.
I prefer to leave it as it was in the main
| * @return Future that contains a result. | ||
| */ | ||
| private CompletableFuture<Void> processWaitReplicaStateMessage(WaitReplicaStateMessage msg) { | ||
| LOG.info("Received WaitReplicaStateMessage for replica belonging to group=" + groupId()); |
There was a problem hiding this comment.
Use our log format.
("WaitReplicaStateMessage was received [group={}]", groupId())
| .enlistmentConsistencyToken(meta.getStartTime().longValue()) | ||
| .groupId(partId) | ||
| // TODO: discuss this timeout |
| * It delegates calls to the original {@link PlacementDriver} and after that sends {@link WaitReplicaStateMessage} | ||
| * which calls {@link org.apache.ignite.internal.replicator.Replica#waitForActualState(long)}. | ||
| */ | ||
| public class ReplicaAwareLeaseTracker extends AbstractEventProducer<PrimaryReplicaEvent, PrimaryReplicaEventParameters> implements |
There was a problem hiding this comment.
I would inject the implementation into the lease tracker.
sanpwc
reviewed
Apr 25, 2024
| @@ -239,6 +239,7 @@ public static int getTableIdStrict(CatalogService catalogService, String tableNa | |||
| return getTableStrict(catalogService, tableName, timestamp).id(); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Horrible, disgusting mistake. Please remove this empty line.
sanpwc
approved these changes
Apr 26, 2024
alievmirza
changed the base branch from
ignite-18991-WIP
to
ignite-collocation-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-21911