WIP: add select_nic method to gridscale fog-extension concern. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2019 16:28
NB: this currently creates an other error with my test setup, as fog-gridscale doesn't set the "interfaces" attribute, which is used by foreman here: https://github.com/theforeman/foreman/blob/c23a83afe9fcd6d2f25d261eb0c303a7cf337ffa/app/models/concerns/orchestration/compute.rb#L339
see according commit for fog-gridscale
rbns
pushed a commit
to bytemine/fog-gridscale
that referenced
this pull request
Aug 26, 2019
foreman uses this during creation of servers as described here: gridscale/foreman-gridscale#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this currently creates another error
with my test setup, as fog-gridscale doesn't set the "interfaces" attribute, which is used by foreman here:
https://github.com/theforeman/foreman/blob/c23a83afe9fcd6d2f25d261eb0c303a7cf337ffa/app/models/concerns/orchestration/compute.rb#L339
just returning
nilin select_nic also doesn't work, as foreman aborts the machine creation withthis could be related to my test-setup, though.